From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYtt8-0001bQ-S6 for qemu-devel@nongnu.org; Thu, 25 Feb 2016 06:15:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYtt6-0004Fl-4r for qemu-devel@nongnu.org; Thu, 25 Feb 2016 06:15:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYtt5-0004Fh-TS for qemu-devel@nongnu.org; Thu, 25 Feb 2016 06:15:16 -0500 Date: Thu, 25 Feb 2016 11:15:13 +0000 From: Stefan Hajnoczi Message-ID: <20160225111513.GA23099@stefanha-x1.localdomain> References: <145625154789.9577.15659725961737992178.stgit@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: <145625154789.9577.15659725961737992178.stgit@localhost> Subject: Re: [Qemu-devel] [PATCH v8 0/6] trace: Show vCPU info in guest code events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-devel@nongnu.org, Eduardo Habkost --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 23, 2016 at 07:19:10PM +0100, Llu=EDs Vilanova wrote: > NOTE: This series should complete the framework for guest code tracing. F= rom > here on, other series can concurrently add actual events and improv= e the > guest code tracing features and performance (e.g., control tracing > independently on each vCPU). >=20 > This series introduces the "vcpu" property for tracing events. This prope= rty > identifies events that are tied to a particular virtual CPU (e.g., execut= ing an > instruction). >=20 > Events with this property have an implicit vcpu argument, which is shown = in the > trace. In the case of events executed at TCG translation time, two implic= it > arguments are added: >=20 > * The vCPU performing the code translation (shown in the translation-time= trace) > * The vCPU executing the translated code (shown in the execution-time tra= ce) >=20 > Note that the "vcpu" and "tcg" properties are not merged into a single on= e, > since events can be defined that relate to a vCPU but are never raised fr= om TCG > code (e.g., interrupts). >=20 >=20 > Changes in v8 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Rebase on 1b16240. > * Minor fix in message formatting ('tracetool.vcpu' module). > * Fix management of event arguments with TCG types. > * Tested with various (non sent) events with different mixes of native an= d TCG arguments. >=20 >=20 > Changes in v7 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Fix the modified event copying code. > * Minor fix in commit message for patch 3. >=20 >=20 > Changes in v6 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Rebase on 84c0781. > * Replace the added 'TCGv_cpu' type for 'TCGv_env', since the users are r= eally > pointing to 'CPUArchState'. > * Add functions to simplify event argument management. > * Add minor event copy cleanup (remove long "event.original.original" cha= ins). > * Make it easier to change arguments injected by the 'vcpu' property. >=20 >=20 > Changes in v5 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Rebase on 357e81c. > * Split from the previous (larger and more complex) v4 series. >=20 >=20 > Changes in v4 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Fix typo in commit message (Stefan Hajnoczi). > * Simplify per-vCPU tracing state initialization (Stefan Hajnoczi). > * Update copyright years. >=20 >=20 > Changes in v3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Update QAPI version (Eric Blake). > * Fix '#optional' annotation in QAPI (Eric Blake). >=20 >=20 > Changes in v2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > * Rebase on 5522a84. > * Improve patch descriptions. > * Refactor code generation into a separate patch. > * Fix forward declarations (Stefan Hajnoczi & Eduardo Habkost). > * Fix "since" tags in QAPI interface (Eric Blake). > * Unify QAPI/QMP interface with an optional 'vcpu' argument (Eric Blake). > * Fix QMP+GTK header workaround (Stefan Hajnoczi). >=20 >=20 > Signed-off-by: Llu=EDs Vilanova > Acked-by: Stefan Hajnoczi > --- >=20 > Llu=EDs Vilanova (6): > trace: Extend API to manage event arguments > trace: Remove unnecessary intermediate event copies > tcg: Add type for vCPU pointers > tcg: Move definition of type TCGv > [trivial] trace: Add helper function to cast event arguments > trace: Add 'vcpu' event property to trace guest vCPU >=20 >=20 > docs/tracing.txt | 41 +++++++++++++ > include/qemu/typedefs.h | 1=20 > scripts/tracetool/__init__.py | 35 +++++++++-- > scripts/tracetool/format/events_h.py | 4 + > scripts/tracetool/format/h.py | 3 + > scripts/tracetool/format/tcg_h.py | 33 +++++++--- > scripts/tracetool/format/tcg_helper_c.py | 45 +++++++++++--- > scripts/tracetool/format/tcg_helper_h.py | 7 +- > scripts/tracetool/format/tcg_helper_wrapper_h.py | 5 +- > scripts/tracetool/format/ust_events_c.py | 1=20 > scripts/tracetool/transform.py | 4 + > scripts/tracetool/vcpu.py | 70 ++++++++++++++++= ++++++ > target-alpha/translate.c | 2 - > target-arm/translate.c | 2 - > target-arm/translate.h | 2 - > target-cris/translate.c | 2 - > target-i386/translate.c | 2 - > target-lm32/translate.c | 2 - > target-m68k/translate.c | 2 - > target-microblaze/translate.c | 2 - > target-mips/translate.c | 2 - > target-moxie/translate.c | 2 - > target-openrisc/translate.c | 2 - > target-ppc/translate.c | 2 - > target-s390x/translate.c | 2 - > target-sh4/translate.c | 2 - > target-sparc/translate.c | 5 +- > target-tilegx/translate.c | 2 - > target-tricore/translate.c | 2 - > target-unicore32/translate.c | 2 - > target-xtensa/translate.c | 2 - > tcg/tcg-op.h | 2 - > tcg/tcg.h | 8 +++ > trace/control.h | 3 + > 34 files changed, 241 insertions(+), 62 deletions(-) > create mode 100644 scripts/tracetool/vcpu.py >=20 >=20 > To: qemu-devel@nongnu.org > Cc: Stefan Hajnoczi > Cc: Eduardo Habkost > Cc: Eric Blake > Cc: Alex Benn=E9e Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWzuJAAAoJEJykq7OBq3PIRHgH/itTYRrJenG4ioVVXiWrZtXm EfIs8GP4K5JIY1ke+Ua91TwxXm3ydC1kv8MU+FJRpUpY+ANVvEn6XOfbtedaPa81 4Xp678IDlcBrFBNamveFEquchce41K56IcF5y8T515u+rekrOX86DPaxjpt8vUk9 KgDeUXk3kaojzBqnHuXvE9j4eYMsLUpFCeHPq+T95zvKGAJeNiorN7vYEv4dsQ22 p9XGlMULvFEBtEGFWCUPwpaOA7DmpLoLsH5rUH3/3EU28+R2z4uOhp5TmESFzWrU 3WNgoRwP+nhaYZyzvXaJshOXDqcp99/ZMYPrTwGyVDelN5LsI80K/bUyZ1UnkvU= =nPjb -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--