From: Peter Krempa <pkrempa@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB
Date: Thu, 25 Feb 2016 13:51:03 +0100 [thread overview]
Message-ID: <20160225125103.GF5757@andariel.pipo.sk> (raw)
In-Reply-To: <56CDEE65.3060906@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Wed, Feb 24, 2016 at 18:54:45 +0100, Max Reitz wrote:
> On 23.02.2016 18:16, Kevin Wolf wrote:
> > Now that we can use drive_add to create new nodes without a BB, we also
> > want to be able to delete such nodes again.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > blockdev.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
[..]
> >
>
> It's a bit strange to require the user to specify the node name using
> "node-name" for drive_add, but the to use "id" in drive_del; especially
> because x-blockdev-del uses "node-name", too.
Well, since 'x-blockdev-del' is considered unstable yet I can't really
use it in libvirt, thus we discussed using drive_del as a workaround.
It makes partially sense since we'd add the new node with 'drive_add' in
the first place.
Peter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-25 12:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 17:16 [Qemu-devel] [PATCH 0/2] block: drive_add/del without BlockBackend Kevin Wolf
2016-02-23 17:16 ` [Qemu-devel] [PATCH 1/2] hmp: 'drive_add -n' for creating a node without BB Kevin Wolf
2016-02-24 17:50 ` Max Reitz
2016-02-24 18:24 ` Kevin Wolf
2016-02-25 13:18 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2016-02-25 16:05 ` Eric Blake
2016-02-23 17:16 ` [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes " Kevin Wolf
2016-02-24 17:54 ` Max Reitz
2016-02-24 18:23 ` Kevin Wolf
2016-02-26 13:09 ` Max Reitz
2016-02-25 12:51 ` Peter Krempa [this message]
2016-02-26 13:11 ` Max Reitz
2016-03-09 10:54 ` [Qemu-devel] [PATCH 0/2] block: drive_add/del without BlockBackend Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225125103.GF5757@andariel.pipo.sk \
--to=pkrempa@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).