From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYvNx-0006Sk-7L for qemu-devel@nongnu.org; Thu, 25 Feb 2016 07:51:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYvNw-0005dG-6E for qemu-devel@nongnu.org; Thu, 25 Feb 2016 07:51:13 -0500 Date: Thu, 25 Feb 2016 13:51:03 +0100 From: Peter Krempa Message-ID: <20160225125103.GF5757@andariel.pipo.sk> References: <1456247799-9593-1-git-send-email-kwolf@redhat.com> <1456247799-9593-3-git-send-email-kwolf@redhat.com> <56CDEE65.3060906@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UBnjLfzoMQYIXCvq" Content-Disposition: inline In-Reply-To: <56CDEE65.3060906@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org --UBnjLfzoMQYIXCvq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 24, 2016 at 18:54:45 +0100, Max Reitz wrote: > On 23.02.2016 18:16, Kevin Wolf wrote: > > Now that we can use drive_add to create new nodes without a BB, we also > > want to be able to delete such nodes again. > >=20 > > Signed-off-by: Kevin Wolf > > --- > > blockdev.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) [..] > >=20 >=20 > It's a bit strange to require the user to specify the node name using > "node-name" for drive_add, but the to use "id" in drive_del; especially > because x-blockdev-del uses "node-name", too. Well, since 'x-blockdev-del' is considered unstable yet I can't really use it in libvirt, thus we discussed using drive_del as a workaround. It makes partially sense since we'd add the new node with 'drive_add' in the first place. Peter --UBnjLfzoMQYIXCvq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzvi3AAoJEDbsFqzQGGgr+a0P/3IftZ5T628TKzB3xzApM+PZ g8Cjw08Ci66hV9XaR50gh+4G4brEUrJpSMQeb0tlxdwSXby/Ii4KBkiglN9U1xWN Ey+fG560syrXUgebEw7nkaxUlYZnYY505NYwnOX6pwvsN/z0VShNQ7+dp/clfdzX 9ebOqmTOX5irCesnbeypfSx3ALogSz7Cpt2ou3/aCqG8j0LNrdOP8OySZveyrVuX aj1ZCMsEp7knypTOCOutkNKYfeopncpVCA7lOulIqbVaCTmF18+tkDHIyvMNg9A6 MfEQCbkW9s3ydBL940aa3gGHKrqpZS5ZzteQbPApXQVv7SznwRm4AjVBMZ7Gvpui UNXdGPsQ8Lpfh+VYAlwHy0i/u96xitrPzQx3XV2/c9Lmw4EaQ6twFvM6PDnNwqw6 nHGtICh4Ba9H8loer+GMjgEZIeZLQoSbKQVdz8XlXH18mbGsHr10P5FOOgJuRPyv 5XRgHV2OQQOvIzSDOwqoXyrHAX47zjXZ/i6YeOBhO0OLFO0EckAmPyqxaATPDCGr JdEWex2NNqzWQJL4/Sbfmo/EwmH7Tc5nS70uxRi1V8xL4JV43Yj4vVlWtZwUeNxS kikm1pCzMkK8x4ioT9rWWisJ9wYXJ/rQa6SqZRkX5wbKc9apM7f9K4OjE/tgCW7w Spl7f6/bggsDXeAeN16j =AgKj -----END PGP SIGNATURE----- --UBnjLfzoMQYIXCvq--