From: Samuel Thibault <samuel.thibault@gnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Jason Wang <jasowang@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Avoid embedding struct mbuf in other structures
Date: Thu, 25 Feb 2016 16:29:36 +0100 [thread overview]
Message-ID: <20160225152936.GA3460@var.bordeaux.inria.fr> (raw)
In-Reply-To: <CAFEAcA8sD+JymC1m9YcdJ0+J4Gy5S=HHCgypc5stDL2d4Z75Fw@mail.gmail.com>
Peter Maydell, on Thu 25 Feb 2016 15:22:25 +0000, wrote:
> On 22 February 2016 at 21:29, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > struct mbuf uses a C99 open char array to allow inlining data.
>
> At the moment it doesn't, it uses a 1 byte array :-) Turning that
> into a C99 flexible array is what we'd like to do...
I know :)
> It's a slight shame that we end up having to have the extra casts,
> but I guess it can't be helped.
Yes.
> Converting the code to use one of the qemu/queue.h data structures
> doesn't seem worth the effort and risk of introducing bugs.
Yes :)
> (Does this pass checkpatch.pl? I wasn't sure about the spacing
> round some of the casts...)
It does, except warnings about indent, which we probably don't want to
fix here.
Samuel
next prev parent reply other threads:[~2016-02-25 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 21:29 [Qemu-devel] [PATCH] Avoid embedding struct mbuf in other structures Samuel Thibault
2016-02-25 15:22 ` Peter Maydell
2016-02-25 15:29 ` Samuel Thibault [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-25 15:30 Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225152936.GA3460@var.bordeaux.inria.fr \
--to=samuel.thibault@gnu.org \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).