From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1aYxrJ-0007MK-7p
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 10:29:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1aYxrG-0006bU-2B
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 10:29:41 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:26862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1aYxrF-0006bL-Rj
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 10:29:37 -0500
Date: Thu, 25 Feb 2016 16:29:36 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160225152936.GA3460@var.bordeaux.inria.fr>
References: <1456176561-31808-1-git-send-email-samuel.thibault@ens-lyon.org>
	<CAFEAcA8sD+JymC1m9YcdJ0+J4Gy5S=HHCgypc5stDL2d4Z75Fw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8sD+JymC1m9YcdJ0+J4Gy5S=HHCgypc5stDL2d4Z75Fw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Avoid embedding struct mbuf in other
	structures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Jason Wang <jasowang@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell, on Thu 25 Feb 2016 15:22:25 +0000, wrote:
> On 22 February 2016 at 21:29, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > struct mbuf uses a C99 open char array to allow inlining data.
> 
> At the moment it doesn't, it uses a 1 byte array :-) Turning that
> into a C99 flexible array is what we'd like to do...

I know :)

> It's a slight shame that we end up having to have the extra casts,
> but I guess it can't be helped.

Yes.

> Converting the code to use one of the qemu/queue.h data structures
> doesn't seem worth the effort and risk of introducing bugs.

Yes :)

> (Does this pass checkpatch.pl? I wasn't sure about the spacing
> round some of the casts...)

It does, except warnings about indent, which we probably don't want to
fix here.

Samuel