From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZGc0-0001uR-SA for qemu-devel@nongnu.org; Fri, 26 Feb 2016 06:31:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZGbw-0006gm-NE for qemu-devel@nongnu.org; Fri, 26 Feb 2016 06:31:08 -0500 Date: Fri, 26 Feb 2016 22:03:02 +1100 From: David Gibson Message-ID: <20160226110302.GB24457@voom.redhat.com> References: <20160218113211.9760.85475.stgit@bahia.huguette.org> <20160219001147.GN15224@voom.fritz.box> <20160219085944.281f4a73@bahia.huguette.org> <20160222010912.GB2808@voom.fritz.box> <20160226114956.7e08af4d@bahia.huguette.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline In-Reply-To: <20160226114956.7e08af4d@bahia.huguette.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] Fix migration of old pseries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Laurent Vivier , Juan Quintela , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , qemu-ppc@nongnu.org, Amit Shah --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 26, 2016 at 11:49:56AM +0100, Greg Kurz wrote: > On Mon, 22 Feb 2016 12:09:12 +1100 > David Gibson wrote: >=20 > > On Fri, Feb 19, 2016 at 08:59:44AM +0100, Greg Kurz wrote: > > > On Fri, 19 Feb 2016 11:11:47 +1100 > > > David Gibson wrote: > > > =20 > > > > On Thu, Feb 18, 2016 at 12:32:11PM +0100, Greg Kurz wrote: =20 > > > > > QEMU 2.4 broke the migration of old pseries machine with the addi= tion > > > > > of configuration sections, which are sent unconditionally. > > > > >=20 > > > > > We assume that QEMU 2.3 is more deployed than any newer release (= based on > > > > > the versions currently shipped by most distros). This v3 series h= ence > > > > > reverses the logic from v2: it now fully fixes migration of old p= series > > > > > from/to QEMU 2.3 and provides a manual workaround for the QEMU 2.= 4/2.4.1/2.5 > > > > > case. > > > > >=20 > > > > > With this series, I could migrate the same pseries-2.3 instance i= n a full > > > > > 2.3->2.6->2.5->2.6->2.4->2.6->2.3 cycle. =20 > > > >=20 > > > > Sorry, I've lost track slightly here. Does this series apply on top > > > > of, or instead of your earlier series that peeks for the config > > > > section? > > > > =20 > > >=20 > > > This v3 series applies instead of the v2 that peeks for the config se= ction. =20 > >=20 > > Ok, thanks for the clarification. > >=20 > > > It was suggested by Laurent during review, and motivated by your deci= sion > > > to favor fixing 2.3 over 2.4. > > >=20 > > > As shown in Laurent's detailed test report, migration from/to 2.3.x n= ow works > > > out of the box and 2.4.x/2.5 requires qom-set. > > >=20 > > > I was also feeling a bit uncomfortable with all these machine propert= ies to > > > disable the configuration section, which was explicitly coded to be n= on-optional > > > according to the changelog of commit 61964c23. The logic inversion in= v3 seem > > > to be friendlier with the configuration section design. > > >=20 > > > Juan, could you share your thoughts ? =20 > >=20 > > With an ack from Juan I'll be happy to merge this to ppc-for-2.6. > >=20 >=20 > And the patches even got reviewed by Juan ! Please merge ! :) Ugh, sorry. Thought I already had. Merged now. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW0DDmAAoJEGw4ysog2bOSrOQP/1lEKkpypCxnaEXeq5clAVUH QGq9yPladFvfJmVIE130B1N5cYwa9c9z5DBZpSUaxXYhbDQM3n1q5T17OZYcE0AH V+f/m+QlVsxs6Q4a9BU4YUfJ/GHfMXcNZNuf7xcOzlrbhcbrmHxCLJFcRBQN+agQ RSL1gmX6R41fGEleCLeNhrNWTXVsLcRoTB5B8gC1FixeAbpn12fvZGWtqk24dAXq HmRnqjP7E72DDfemJ//zqU5V9FRRJBvnUH/RiwCMY80gSRhqnJXSAATA1k4EcCt3 TD7Z44k3XRBlfJnHbRnQ0v65lTN2Khgn1A3YuQLPDSHsOWOay0wJmCtIpVI24XYi p/ihK6/H4XVw13h3/4ZSYduJ2CoDEPCEcihAKB0LpLp6aP66qjpsd2XQroBw8nFC 85lT4w7Bz3+wlUrON8IkW6JfgtRfrZENV1DK9LncQv9Lop3JlhUkj24TsyHEuSDZ nulmC04I5oNccrQMKA6eJTj1uOfDcmiasyaC2HPp5P4cArpq9cKe5s9hoT0d3ZwI doB0md+PXqc2C64mDwW3qbLh4mj/WQH6PBxIpNtL9AL2z9mzuDxD7XW/jENl40RX EweIKZ1WtENQzWeVdVwRSQ3fB1Y2h2zfN1eJ/zJTAgKGvTAZEv0ZNwUrB9QnsDde 7x7oxIwECnQ7gJoHrQF3 =BOGp -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE--