From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42815)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aZaHO-0003t8-Fl
	for qemu-devel@nongnu.org; Sat, 27 Feb 2016 03:31:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aZaHN-0008Rx-NR
	for qemu-devel@nongnu.org; Sat, 27 Feb 2016 03:31:10 -0500
Date: Sat, 27 Feb 2016 16:30:59 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160227083059.GC12620@ad.usersys.redhat.com>
References: <1453270306-16608-1-git-send-email-famz@redhat.com>
	<1453270306-16608-6-git-send-email-famz@redhat.com>
	<56A79883.3040703@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56A79883.3040703@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v2 05/13] block: Hide HBitmap in block
 dirty bitmap interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Tue, 01/26 19:02, Vladimir Sementsov-Ogievskiy wrote:
> 
> why? The old way works for meta iters. The new code - doesn't. I suppose
> 
> assert(iter->hbi.hb);
> hbitmap_iter_init(&iter->hbi, iter->hbi.hb, sector_num);

Okay, will change.

Fam