From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaGct-0006CU-2D for qemu-devel@nongnu.org; Mon, 29 Feb 2016 00:44:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaGcp-0002Y8-7V for qemu-devel@nongnu.org; Mon, 29 Feb 2016 00:44:11 -0500 Received: from e28smtp06.in.ibm.com ([125.16.236.6]:45145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaGco-0002Wg-Ap for qemu-devel@nongnu.org; Mon, 29 Feb 2016 00:44:07 -0500 Received: from localhost by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Feb 2016 11:14:01 +0530 Date: Mon, 29 Feb 2016 11:13:53 +0530 From: Bharata B Rao Message-ID: <20160229054353.GD5756@in.ibm.com> References: <1456417362-20652-1-git-send-email-bharata@linux.vnet.ibm.com> <1456417362-20652-6-git-send-email-bharata@linux.vnet.ibm.com> <56D0760D.1000702@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56D0760D.1000702@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: mjrosato@linux.vnet.ibm.com, agraf@suse.de, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au On Fri, Feb 26, 2016 at 08:58:05AM -0700, Eric Blake wrote: > On 02/25/2016 09:22 AM, Bharata B Rao wrote: > > Implement query cpu-slots that provides information about hot-plugged > > as well as hot-pluggable CPU slots that the machine supports. > > > > TODO: As Eric suggested use enum for type instead of str. > > TODO: @hotplug-granularity probably isn't required. > > I guess this is still marked TODO because the series is still RFC? Yes. > > > > > Signed-off-by: Bharata B Rao > > --- > > > +++ b/qapi-schema.json > > @@ -4083,3 +4083,88 @@ > > ## > > { 'enum': 'ReplayMode', > > 'data': [ 'none', 'record', 'play' ] } > > + > > +## > > +# @CPUInfo: > > +# > > +# Information about CPUs > > +# > > +# @arch-id: Arch-specific ID for the CPU. > > +# > > +# @type: QOM type of the CPU. > > +# > > +# @thread: Thread ID of the CPU. > > +# > > +# @core: Core ID of the CPU. > > +# > > +# @socket: Socket ID of the CPU. > > +# > > +# @node: NUMA node to which the CPU belongs. > > Please add the '#optional' tag to the fields which are not always present. > Sure. > > +# > > +# @qom-path: QOM path of the CPU object > > +# > > +# Since: 2.6 > > +## > > + > > +{ 'struct': 'CPUInfo', > > + 'data': { 'arch-id': 'int', > > + 'type': 'str', > > The TODO in the commit message mentions that this should be converted to > an enum. > > > + '*thread': 'int', > > + '*core': 'int', > > + '*socket' : 'int', > > + '*node' : 'int', > > + '*qom-path': 'str' > > + } > > But looking better than the previous round. Thanks for the review. Do you have any comments on the applicability/suitability of this interface from libvirt point of view for performing device_add based CPU hotplug ? Regards, Bharata.