From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1aaTyT-0001l1-TU
	for qemu-devel@nongnu.org; Mon, 29 Feb 2016 14:59:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1aaTyS-0003VW-S8
	for qemu-devel@nongnu.org; Mon, 29 Feb 2016 14:59:21 -0500
Date: Mon, 29 Feb 2016 14:59:10 -0500
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20160229195910.GC26318@localhost.localdomain>
References: <1456433911-24718-1-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456433911-24718-1-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] blockjob: correct backup cluster
	size for backups
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, stefanha@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Thu, Feb 25, 2016 at 03:58:28PM -0500, John Snow wrote:
> Backups sometimes need a non-64KiB transfer cluster size.
> See patch #2 for the detailed justificaton.
> 
> ===
> v4:
> ===
> 
> 02: Polished the error message.
> 
> ===
> v3:
> ===
> 
> 01: +R-B
> 02: Added failure mode for bdrv_get_info, including critical failure for when
>     we don't have a backing file but couldn't retrieve the cluster_size info.
> 
> ===
> v2:
> ===
> 
> 01: Removed "sectors_per_cluster" as a cached property of the Backup Block Job,
>     In favor of recomputing it with a small function where needed.
>     (I like v1 more. Thoughts?)
> 02: Expand correction to all backup modes instead of just incremental.
>     Added credit: Thanks to Fam Z for noticing this problem!
> 03: Minor phrasing change in a comment.
>     Added r-b.
> 
> ________________________________________________________________________________
> 
> For convenience, this branch is available at:
> https://github.com/jnsnow/qemu.git branch incremental-granularity-fix
> https://github.com/jnsnow/qemu/tree/incremental-granularity-fix
> 
> This version is tagged incremental-granularity-fix-v4:
> https://github.com/jnsnow/qemu/releases/tag/incremental-granularity-fix-v4
> 
> John Snow (3):
>   block/backup: make backup cluster size configurable
>   block/backup: avoid copying less than full target clusters
>   iotests/124: Add cluster_size mismatch test
> 
>  block/backup.c             | 87 ++++++++++++++++++++++++++++++----------------
>  tests/qemu-iotests/124     | 58 ++++++++++++++++++++++++++++---
>  tests/qemu-iotests/124.out |  4 +--
>  3 files changed, 112 insertions(+), 37 deletions(-)
> 
> -- 
> 2.4.3
> 

Thanks, applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc.git block


Jeff