From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaaKu-0005sk-Vh for qemu-devel@nongnu.org; Mon, 29 Feb 2016 21:46:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaaKq-0002tR-VH for qemu-devel@nongnu.org; Mon, 29 Feb 2016 21:46:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaaKq-0002tF-PV for qemu-devel@nongnu.org; Mon, 29 Feb 2016 21:46:52 -0500 Date: Tue, 1 Mar 2016 10:46:45 +0800 From: Fam Zheng Message-ID: <20160301024645.GG15213@ad.usersys.redhat.com> References: <1456713443-16834-1-git-send-email-famz@redhat.com> <1456713443-16834-4-git-send-email-famz@redhat.com> <33183CC9F5247A488A2544077AF19020B02EA3D8@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020B02EA3D8@SZXEMA503-MBS.china.huawei.com> Subject: Re: [Qemu-devel] [PATCH 3/6] memory: Implement memory_region_get_ram_addr with mr->ram_block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: Paolo Bonzini , "qemu-devel@nongnu.org" On Tue, 03/01 02:32, Gonglei (Arei) wrote: > > > Subject: [Qemu-devel] [PATCH 3/6] memory: Implement > > memory_region_get_ram_addr with mr->ram_block > > > > Signed-off-by: Fam Zheng > > --- > > include/exec/memory.h | 8 +------- > > memory.c | 5 +++++ > > 2 files changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/include/exec/memory.h b/include/exec/memory.h > > index d5284c2..810d2c0 100644 > > --- a/include/exec/memory.h > > +++ b/include/exec/memory.h > > @@ -978,14 +978,8 @@ void > > memory_region_add_subregion_overlap(MemoryRegion *mr, > > /** > > * memory_region_get_ram_addr: Get the ram address associated with a > > memory > > * region > > - * > > - * DO NOT USE THIS FUNCTION. This is a temporary workaround while the > > Xen > > - * code is being reworked. > > */ > > -static inline ram_addr_t memory_region_get_ram_addr(MemoryRegion *mr) > > -{ > > - return mr->ram_addr; > > -} > > +ram_addr_t memory_region_get_ram_addr(MemoryRegion *mr); > > > > uint64_t memory_region_get_alignment(const MemoryRegion *mr); > > /** > > diff --git a/memory.c b/memory.c > > index fe70075..769825e 100644 > > --- a/memory.c > > +++ b/memory.c > > @@ -1596,6 +1596,11 @@ void > > *memory_region_get_ram_ptr(MemoryRegion *mr) > > return ptr + offset; > > } > > > > +ram_addr_t memory_region_get_ram_addr(MemoryRegion *mr) > > +{ > > + return mr->ram_block->offset; > > +} > > + > > Do we need add NULL check for mr->ram_block ? Yes, will add it. Thanks! Fam