From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aakU2-0004hH-U0 for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aakTz-0004JZ-Oh for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:37:02 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:33165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aakTz-0004JL-HZ for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:36:59 -0500 Received: by mail-wm0-x22c.google.com with SMTP id l68so35779044wml.0 for ; Tue, 01 Mar 2016 05:36:59 -0800 (PST) Date: Tue, 1 Mar 2016 13:36:57 +0000 From: Stefan Hajnoczi Message-ID: <20160301133657.GC6168@stefanha-x1.localdomain> References: <1455036545-14870-1-git-send-email-den@openvz.org> <20160211154505.GA10359@stefanha-x1.localdomain> <56D58455.8040605@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dkEUBIird37B8yKS" Content-Disposition: inline In-Reply-To: <56D58455.8040605@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Peter Maydell , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , "Denis V. Lunev" , Alex =?iso-8859-1?Q?Benn=E9e?= --dkEUBIird37B8yKS Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 01, 2016 at 01:00:21PM +0100, Christian Borntraeger wrote: > On 02/11/2016 04:45 PM, Stefan Hajnoczi wrote: > > On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote: > >> we should call trace_init_backends() before trace_init_file() for > >> CONFIG_TRACE_SIMPLE There is no difference for other cases. > >> > >> This problem was introduced by the commit > >> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f > >> Author: Paolo Bonzini > >> Date: Thu Jan 7 16:55:24 2016 +0300 > >> > >> trace: split trace_init_file out of trace_init_backends > >> > >> 'make check' was failed as a result if configured with > >> --enable-trace-backends=3Dsimple > >> > >> Spotted by Alex Benn=E9e. > >> > >> Signed-off-by: Denis V. Lunev > >> CC: Alex Benn=E9e > >> CC: Paolo Bonzini > >> CC: Stefan Hajnoczi > >> --- > >> vl.c | 7 +++---- > >> 1 file changed, 3 insertions(+), 4 deletions(-) > >=20 > > Thanks, applied to my tracing tree: > > https://github.com/stefanha/qemu/commits/tracing > >=20 > > Stefan >=20 > When is this scheduled for integration? Without that patch not > only make check is broken, libvirt will also hang if qemu was=20 > build with --enable-trace-backends=3Dsimple during capability > detection. I am sending a tracing pull request with this patch today. Stefan --dkEUBIird37B8yKS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW1Zr5AAoJEJykq7OBq3PI9usH/ArRQUxcn+9LjxObqNZkavwO apnvOPsLsGH3YqJSdFzGG5H1HNme+0/8/WbIoMotc77JQ07nc6KjiQ+mMeEEi05Q ojBUMWpvJ2ptENj6ik4Lm/1e/5gkuCdupNcy5raoa4sjZz7yNROTrtoit7Hyv5fY 73YKDfMDZPqfe05dmjVHNPmTBVF5G9VZhDtbY3Fk6/qs/ikls9ZliKE6kPDNSxr/ jUA7NIPnHztPg/lhEXtgrM1BliDlLHK34xAItfWJqwFfOS5yQG2ScnczRfOEDf9A GmZIBEUzTkCsBs86EOtHgncUM355D8riLYcz4T58HCFoao4KYYJdYaWOKJCTQUg= =kIhZ -----END PGP SIGNATURE----- --dkEUBIird37B8yKS--