From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaxcp-0001n6-UW for qemu-devel@nongnu.org; Tue, 01 Mar 2016 22:39:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaxcm-00010N-NC for qemu-devel@nongnu.org; Tue, 01 Mar 2016 22:38:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaxcm-000100-HP for qemu-devel@nongnu.org; Tue, 01 Mar 2016 22:38:56 -0500 Date: Wed, 2 Mar 2016 11:38:50 +0800 From: Fam Zheng Message-ID: <20160302033850.GD20565@ad.usersys.redhat.com> References: <1455626399-7111-1-git-send-email-famz@redhat.com> <1455626399-7111-16-git-send-email-famz@redhat.com> <8737sadkd0.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <8737sadkd0.fsf@linaro.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 15/15] tests/docker/Makefile.include: snapshot the src for docker List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini , jsnow@redhat.com, david@gibson.dropbear.id.au On Tue, 03/01 20:16, Alex Benn=E9e wrote: >=20 > Fam Zheng writes: >=20 > > From: Alex Benn=E9e > > > > Instead of providing a live version of the source tree to the docker > > container we snapshot it with git-archive. This ensure the tree is in= a > > pristine state for whatever operations the container is going to run = on > > them. > > > > Uncommitted changes known to files known by the git index will be > > included in the snapshot if there are any. > > > > Signed-off-by: Alex Benn=E9e > > [Generate an unique directory under /tmp/ - Fam Zheng] >=20 > But the docker-run-% rule never uses the source copy we just made. I failed in Makefile magic: pattern rules and dynamically generated rules mustn't be used mixed, otherwise the former will be ignored. Will fix. Fam