From: Amit Shah <amit.shah@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, pagupta@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend
Date: Wed, 2 Mar 2016 12:45:47 +0530 [thread overview]
Message-ID: <20160302071547.GA15443@grmbl.mre> (raw)
In-Reply-To: <1455119605-31261-4-git-send-email-lprosek@redhat.com>
On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote:
> RngBackend is now in charge of cleaning up the linked list on
> instance finalization. It also exposes a function to finalize
> individual RngRequest instances, called by its child classes.
>
> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
> @@ -183,8 +162,6 @@ static void rng_egd_finalize(Object *obj)
> }
>
> g_free(s->chr_name);
> -
> - rng_egd_free_requests(s);
Missing call to rng_backend_free_requests()?
> diff --git a/include/sysemu/rng.h b/include/sysemu/rng.h
> index 084164c..c2c9035 100644
> --- a/include/sysemu/rng.h
> +++ b/include/sysemu/rng.h
> @@ -61,6 +61,7 @@ struct RngBackend
> GSList *requests;
> };
>
> +
> /**
Extra whitespace?
Amit
next prev parent reply other threads:[~2016-03-02 7:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 15:53 [Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue Ladi Prosek
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 1/4] rng: remove the unused request cancellation code Ladi Prosek
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 2/4] rng: move request queue from RngEgd to RngBackend Ladi Prosek
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup " Ladi Prosek
2016-03-02 7:15 ` Amit Shah [this message]
2016-03-02 8:32 ` Ladi Prosek
2016-03-02 9:56 ` Amit Shah
2016-02-10 15:53 ` [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random Ladi Prosek
2016-02-10 16:23 ` Paolo Bonzini
2016-02-10 16:40 ` Ladi Prosek
2016-02-10 16:40 ` Paolo Bonzini
2016-03-02 9:56 ` Amit Shah
2016-03-02 10:07 ` Ladi Prosek
2016-02-15 13:36 ` [Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302071547.GA15443@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=lprosek@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).