From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ab10o-00083V-Eg
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:15:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ab10j-0008Nr-FC
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:15:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49459)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ab10j-0008Ne-A9
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:15:53 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 75CB8335E9B
	for <qemu-devel@nongnu.org>; Wed,  2 Mar 2016 07:15:52 +0000 (UTC)
Date: Wed, 2 Mar 2016 12:45:47 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20160302071547.GA15443@grmbl.mre>
References: <1455119605-31261-1-git-send-email-lprosek@redhat.com>
	<1455119605-31261-4-git-send-email-lprosek@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455119605-31261-4-git-send-email-lprosek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup
 from RngEgd to RngBackend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ladi Prosek <lprosek@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, pagupta@redhat.com

On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote:
> RngBackend is now in charge of cleaning up the linked list on
> instance finalization. It also exposes a function to finalize
> individual RngRequest instances, called by its child classes.
> 
> Signed-off-by: Ladi Prosek <lprosek@redhat.com>

> @@ -183,8 +162,6 @@ static void rng_egd_finalize(Object *obj)
>      }
>  
>      g_free(s->chr_name);
> -
> -    rng_egd_free_requests(s);

Missing call to rng_backend_free_requests()?

> diff --git a/include/sysemu/rng.h b/include/sysemu/rng.h
> index 084164c..c2c9035 100644
> --- a/include/sysemu/rng.h
> +++ b/include/sysemu/rng.h
> @@ -61,6 +61,7 @@ struct RngBackend
>      GSList *requests;
>  };
>  
> +
>  /**

Extra whitespace?


		Amit