From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab1gu-00064x-TF for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:59:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ab1gr-0001vx-MF for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:59:28 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:44682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab1gr-0001vL-CM for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:59:25 -0500 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Mar 2016 07:59:24 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 26D341B08061 for ; Wed, 2 Mar 2016 07:59:45 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u227xMRc64946176 for ; Wed, 2 Mar 2016 07:59:22 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u227xLfs018522 for ; Wed, 2 Mar 2016 00:59:22 -0700 Date: Wed, 2 Mar 2016 08:59:20 +0100 From: David Hildenbrand Message-ID: <20160302085920.31132938@thinkpad-w530> In-Reply-To: <1456866806-31466-6-git-send-email-mjrosato@linux.vnet.ibm.com> References: <1456866806-31466-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1456866806-31466-6-git-send-email-mjrosato@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato Cc: imammedo@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net > Check for and propogate errors during s390 cpu creation. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-virtio-ccw.c | 30 +++++++++++++++++++++ > hw/s390x/s390-virtio.c | 2 +- > hw/s390x/s390-virtio.h | 1 + > target-s390x/cpu-qom.h | 3 +++ > target-s390x/cpu.c | 65 ++++++++++++++++++++++++++++++++++++++++++++-- > target-s390x/cpu.h | 1 + > target-s390x/helper.c | 31 ++++++++++++++++++++-- > 7 files changed, 128 insertions(+), 5 deletions(-) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 3090e76..4886dbf 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -112,6 +112,36 @@ void s390_memory_init(ram_addr_t mem_size) > s390_skeys_init(); > } > > +S390CPU *s390_new_cpu(MachineState *machine, int64_t id, Error **errp) Just a thought, if not passing machine but the model string, we could make cpu_s390x_init() call s390_new_cpu(). But then s390_new_cpu() would have to be moved again. Not sure if this is really worth it. David