From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab3WO-0000ES-C1 for qemu-devel@nongnu.org; Wed, 02 Mar 2016 04:56:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ab3WN-0000QC-Fb for qemu-devel@nongnu.org; Wed, 02 Mar 2016 04:56:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab3WN-0000Q2-B7 for qemu-devel@nongnu.org; Wed, 02 Mar 2016 04:56:43 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E795F29B32A for ; Wed, 2 Mar 2016 09:56:42 +0000 (UTC) Date: Wed, 2 Mar 2016 15:26:38 +0530 From: Amit Shah Message-ID: <20160302095638.GC15443@grmbl.mre> References: <1455119605-31261-1-git-send-email-lprosek@redhat.com> <1455119605-31261-4-git-send-email-lprosek@redhat.com> <20160302071547.GA15443@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek Cc: Paolo Bonzini , qemu-devel@nongnu.org, pagupta On (Wed) 02 Mar 2016 [09:32:48], Ladi Prosek wrote: > On Wed, Mar 2, 2016 at 8:15 AM, Amit Shah wrote: > > On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote: > >> RngBackend is now in charge of cleaning up the linked list on > >> instance finalization. It also exposes a function to finalize > >> individual RngRequest instances, called by its child classes. > >> > >> Signed-off-by: Ladi Prosek > > > >> @@ -183,8 +162,6 @@ static void rng_egd_finalize(Object *obj) > >> } > >> > >> g_free(s->chr_name); > >> - > >> - rng_egd_free_requests(s); > > > > Missing call to rng_backend_free_requests()? > > Not needed here, this is handled by the parent class. Its > instance_finalize callback calls rng_backend_free_requests. OK. > >> diff --git a/include/sysemu/rng.h b/include/sysemu/rng.h > >> index 084164c..c2c9035 100644 > >> --- a/include/sysemu/rng.h > >> +++ b/include/sysemu/rng.h > >> @@ -61,6 +61,7 @@ struct RngBackend > >> GSList *requests; > >> }; > >> > >> + > >> /** > > > > Extra whitespace? > > This was intentional to separate internal declarations and public > entry points. Same thing exists for example in tpm_backend.h in the > same directory. I can certainly delete the empty line if you'd prefer > that. No, this is fine, and I agree with the separation. Amit