Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

[Peter Xu <peterx@redhat.com>]

On Wed, Mar 02, 2016 at 10:47:39AM +0100, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
> > If temporarily not considering kernel_irqchip=split case:
> >
> > [{
> >     "version": 2,
> >     "emulated": true,
> >     "kernel": true
> > },
> > {
> >     "version": 3,
> >     "emulated": false,
> >     "kernel": true
> > }]
> >
> > To use array rather than dict so that we do not need to change qapi
> > schema again when GICv4 comes.
> 
> Drive-by shooting without sufficient context: we may *want* to change
> the QAPI schema, because that makes the change introspectable with
> query-schema.

Failed to catch the point. :(

What's "query-schema"? Is that a QMP command?

What I meant is that, we can define the following (for example):

{ 'struct': 'GICCapInfo',
  'data': [
    'version': 'int',
    'emulated': 'bool',
    'kernel': 'bool'] }

And:

{ 'command': 'query-gic-capability',
  'returns': ['GICCapInfo'] }

So we can keep this schema as it is when new versions arrive. We
can just push another element in.

Peter