From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab4Zd-0004xH-Gw for qemu-devel@nongnu.org; Wed, 02 Mar 2016 06:04:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ab4Za-0003X9-PG for qemu-devel@nongnu.org; Wed, 02 Mar 2016 06:04:09 -0500 Date: Wed, 2 Mar 2016 19:03:49 +0800 From: Fam Zheng Message-ID: <20160302110349.GG20565@ad.usersys.redhat.com> References: <1456178827-6419-1-git-send-email-jsnow@redhat.com> <20160302104838.GA11268@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160302104838.GA11268@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] blockjob: correct backup cluster size for backups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-block@nongnu.org, Jeff Cody , qemu-devel@nongnu.org, stefanha@redhat.com, John Snow On Wed, 03/02 10:48, Stefan Hajnoczi wrote: > On Mon, Feb 22, 2016 at 05:07:04PM -0500, John Snow wrote: > > Backups sometimes need a non-64KiB transfer cluster size. > > See patch #2 for the detailed justificaton. > > > > === > > v2 > > === > > > > 01: Removed "sectors_per_cluster" as a cached property of the Backup Block Job, > > In favor of recomputing it with a small function where needed. > > (I like v1 more. Thoughts?) > > 02: Expand correction to all backup modes instead of just incremental. > > Added credit: Thanks to Fam Z for noticing this problem! > > 03: Minor phrasing change in a comment. > > Added r-b. > > > > ________________________________________________________________________________ > > > > For convenience, this branch is available at: > > https://github.com/jnsnow/qemu.git branch incremental-granularity-fix > > https://github.com/jnsnow/qemu/tree/incremental-granularity-fix > > > > This version is tagged incremental-granularity-fix-v2: > > https://github.com/jnsnow/qemu/releases/tag/incremental-granularity-fix-v2 > > > > John Snow (3): > > block/backup: make backup cluster size configurable > > block/backup: avoid copying less than full target clusters > > iotests/124: Add cluster_size mismatch test > > > > block/backup.c | 72 ++++++++++++++++++++++++++++------------------ > > tests/qemu-iotests/124 | 58 +++++++++++++++++++++++++++++++++---- > > tests/qemu-iotests/124.out | 4 +-- > > 3 files changed, 99 insertions(+), 35 deletions(-) > > Please CC Jeff Cody. He maintains block jobs. Jeff was Cc'ed. This series has already being applied and merged. :) Fam