From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ab8Qc-0008Q1-4r
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 10:11:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ab8QY-00088T-U1
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 10:11:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56992)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ab8QY-00088A-OJ
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 10:11:02 -0500
Date: Wed, 2 Mar 2016 17:10:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160302171039-mutt-send-email-mst@redhat.com>
References: <1455733533-12030-1-git-send-email-rkagan@virtuozzo.com>
	<56D701F9.3000901@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56D701F9.3000901@openvz.org>
Subject: Re: [Qemu-devel] [PATCH v8 0/4] i386: expose floppy-related objects
	in SSDT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org, Kevin O'Connor <kevin@koconnor.net>, Roman Kagan <rkagan@virtuozzo.com>, Marcel Apfelbaum <marcel@redhat.com>, Igor Mammedov <imammedo@redhat.com>, John Snow <jsnow@redhat.com>

On Wed, Mar 02, 2016 at 06:08:41PM +0300, Denis V. Lunev wrote:
> On 02/17/2016 09:25 PM, Roman Kagan wrote:
> >Windows on UEFI systems is only capable of detecting the presence and
> >the type of floppy drives via corresponding ACPI objects.
> >
> >Those objects are added in patch 4; the preceding ones pave the way to
> >it, by making the necessary data public and by moving the whole floppy
> >drive controller description into runtime-generated SSDT.
> >
> >Roman Kagan (4):
> >   i386/acpi: make floppy controller object dynamic
> >   i386: expose floppy drive CMOS type
> >   fdc: add function to determine drive chs limits
> >   i386: populate floppy drive information in DSDT
> >
> >Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> >Cc: Igor Mammedov <imammedo@redhat.com>
> >Cc: "Michael S. Tsirkin" <mst@redhat.com>
> >Cc: Marcel Apfelbaum <marcel@redhat.com>
> >Cc: John Snow <jsnow@redhat.com>
> >Cc: Laszlo Ersek <lersek@redhat.com>
> >Cc: Kevin O'Connor <kevin@koconnor.net>
> >---
> >changes since v7:
> >  - rebased to latest master
> >  - use drive max c,h,s rather than the current diskette geometry
> >
> >  hw/block/fdc.c         | 23 +++++++++++++
> >  hw/i386/acpi-build.c   | 92 ++++++++++++++++++++++++++++++++++++--------------
> >  hw/i386/pc.c           |  2 +-
> >  include/hw/block/fdc.h |  2 ++
> >  include/hw/i386/pc.h   |  1 +
> >  5 files changed, 94 insertions(+), 26 deletions(-)
> >
> Michael, we have obtained Reviwed-by: from John.
> Does this set is good to be accepted or your
> last comment is mandatory?

Pls do but you can make it a separate patch on top
if you prefer.