From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abB6T-00030d-C7 for qemu-devel@nongnu.org; Wed, 02 Mar 2016 13:02:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abB6O-0002Aq-Dg for qemu-devel@nongnu.org; Wed, 02 Mar 2016 13:02:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abB6O-0002Am-8I for qemu-devel@nongnu.org; Wed, 02 Mar 2016 13:02:24 -0500 Date: Wed, 2 Mar 2016 20:02:20 +0200 From: "Michael S. Tsirkin" Message-ID: <20160302200147-mutt-send-email-mst@redhat.com> References: <1456913698-11452-1-git-send-email-clg@fr.ibm.com> <1456913698-11452-3-git-send-email-clg@fr.ibm.com> <20160302122030-mutt-send-email-mst@redhat.com> <56D72884.6050501@fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <56D72884.6050501@fr.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Marcel Apfelbaum , Corey Minyard , qemu-devel@nongnu.org On Wed, Mar 02, 2016 at 06:53:08PM +0100, C=E9dric Le Goater wrote: > > typedef struct RspBuffer RspBuffer; >=20 > OK. So that's the rule for structs in qemu. It is not that clear > when you look at the code around. I will change. np. Did you look at CODING_STYLE? Pls do.