From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abS2d-000851-11 for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:07:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abS2Z-0004cw-RK for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:07:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abS2Z-0004cd-M2 for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:07:35 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 69303627C5 for ; Thu, 3 Mar 2016 12:07:35 +0000 (UTC) Date: Thu, 3 Mar 2016 17:37:27 +0530 From: Amit Shah Message-ID: <20160303120659.GF15443@grmbl.mre> References: <1456994238-9585-1-git-send-email-lprosek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456994238-9585-1-git-send-email-lprosek@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/4] rng-random: implement request queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, pagupta@redhat.com On (Thu) 03 Mar 2016 [09:37:14], Ladi Prosek wrote: > As suggested by Paolo, I have moved the RngRequest implementation > up to the RngBackend parent class and made both child classes use > it. Apart from the refactoring, the only functional change > compared to v1 is the use of heap instead of stack allocation for > the read buffer in rng-random. > > The parent class takes care of creating new requests and adding > them to the queue, as well as removing them from the queue and > deleting them. Child classes have access to the raw GSList * to > do whatever else they need to do (walk the queue, peek the head > of the queue, ..) > > Changes from v2: > - updated commit message in 1/4 and 4/4 as requested by Amit Reviewed-by: Amit Shah Thanks, Amit