From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abS3B-0000D3-9J for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:08:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abS3A-0004ww-IJ for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:08:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abS3A-0004wi-9F for qemu-devel@nongnu.org; Thu, 03 Mar 2016 07:08:12 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0E166C00070E for ; Thu, 3 Mar 2016 12:08:12 +0000 (UTC) Date: Thu, 3 Mar 2016 17:38:05 +0530 From: Amit Shah Message-ID: <20160303120805.GG15443@grmbl.mre> References: <1456998514-19271-1-git-send-email-lprosek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456998514-19271-1-git-send-email-lprosek@redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-rng: ask for more data if queue is not fully drained List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek Cc: pbonzini@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, pagupta@redhat.com On (Thu) 03 Mar 2016 [10:48:34], Ladi Prosek wrote: > This commit effectively reverts: > > commit 4621c1768ef5d12171cca2aa1473595ecb9f1c9e > Author: Amit Shah > Date: Wed Nov 21 11:21:19 2012 +0530 > > virtio-rng: remove extra request for entropy > > but instead of calling virtio_rng_process unconditionally, it > first checks to see if the queue is empty as a little bit of > optimization. > > Signed-off-by: Ladi Prosek Reviewed-by: Amit Shah Amit