From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTnK-0002IM-4H for qemu-devel@nongnu.org; Thu, 03 Mar 2016 08:59:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abTnF-0000xI-EK for qemu-devel@nongnu.org; Thu, 03 Mar 2016 08:59:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTnF-0000xE-14 for qemu-devel@nongnu.org; Thu, 03 Mar 2016 08:59:53 -0500 Date: Thu, 3 Mar 2016 14:59:49 +0100 From: Igor Mammedov Message-ID: <20160303145949.1f89d33c@nial.brq.redhat.com> In-Reply-To: <1456997052-31822-1-git-send-email-caoj.fnst@cn.fujitsu.com> References: <1456997052-31822-1-git-send-email-caoj.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: mst@redhat.com, qemu-devel@nongnu.org, david@gibson.dropbear.id.au, ehabkost@redhat.com On Thu, 3 Mar 2016 17:24:12 +0800 Cao jin wrote: > correct comment and remove an unused macro. commit adcb4ee6 already > correct its type > > Signed-off-by: Cao jin Reviewed-by: Igor Mammedov > --- > Btw, in pc_memory_init(), I don`t see in which condition, the following code > will be executed: > > if ((pcms->hotplug_memory.base + hotplug_mem_size) < > hotplug_mem_size) { > error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT, > machine->maxram_size); > exit(EXIT_FAILURE); > } > > I appreciate if anyone could give a hint Integer overflow? > > And PS: the output of *get_maintainer.pl this_patch* isn`t the same as > *get_maintainer.pl -f include/hw/mem/pc-dimm.h*. > I am not sure if it is a problem. > > include/hw/mem/pc-dimm.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h > index 218dfb0..8cdc326 100644 > --- a/include/hw/mem/pc-dimm.h > +++ b/include/hw/mem/pc-dimm.h > @@ -20,8 +20,6 @@ > #include "sysemu/hostmem.h" > #include "hw/qdev.h" > > -#define DEFAULT_PC_DIMMSIZE (1024*1024*1024) > - > #define TYPE_PC_DIMM "pc-dimm" > #define PC_DIMM(obj) \ > OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM) > @@ -72,7 +70,7 @@ typedef struct PCDIMMDeviceClass { > > /** > * MemoryHotplugState: > - * @base: address in guest RAM address space where hotplug memory > + * @base: address in guest physical address space where hotplug memory > * address space begins. > * @mr: hotplug memory address space container > */