From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abY0l-0001pZ-QL for qemu-devel@nongnu.org; Thu, 03 Mar 2016 13:30:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abY0h-0000ay-GC for qemu-devel@nongnu.org; Thu, 03 Mar 2016 13:30:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abY0h-0000Zv-Az for qemu-devel@nongnu.org; Thu, 03 Mar 2016 13:30:03 -0500 Date: Thu, 3 Mar 2016 20:29:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20160303202932-mutt-send-email-mst@redhat.com> References: <1455733533-12030-1-git-send-email-rkagan@virtuozzo.com> <56D701F9.3000901@openvz.org> <20160302171039-mutt-send-email-mst@redhat.com> <20160303154838.GB9100@rkaganb.sw.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160303154838.GB9100@rkaganb.sw.ru> Subject: Re: [Qemu-devel] [PATCH v8 0/4] i386: expose floppy-related objects in SSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Kagan , "Denis V. Lunev" , qemu-devel@nongnu.org, Igor Mammedov , Marcel Apfelbaum , John Snow , Laszlo Ersek , Kevin O'Connor On Thu, Mar 03, 2016 at 06:48:38PM +0300, Roman Kagan wrote: > On Wed, Mar 02, 2016 at 05:10:58PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 02, 2016 at 06:08:41PM +0300, Denis V. Lunev wrote: > > > On 02/17/2016 09:25 PM, Roman Kagan wrote: > > > >Windows on UEFI systems is only capable of detecting the presence and > > > >the type of floppy drives via corresponding ACPI objects. > > > > > > > >Those objects are added in patch 4; the preceding ones pave the way to > > > >it, by making the necessary data public and by moving the whole floppy > > > >drive controller description into runtime-generated SSDT. > > > > > > > >Roman Kagan (4): > > > > i386/acpi: make floppy controller object dynamic > > > > i386: expose floppy drive CMOS type > > > > fdc: add function to determine drive chs limits > > > > i386: populate floppy drive information in DSDT > > > > > > > >Signed-off-by: Roman Kagan > > > >Cc: Igor Mammedov > > > >Cc: "Michael S. Tsirkin" > > > >Cc: Marcel Apfelbaum > > > >Cc: John Snow > > > >Cc: Laszlo Ersek > > > >Cc: Kevin O'Connor > > > >--- > > > >changes since v7: > > > > - rebased to latest master > > > > - use drive max c,h,s rather than the current diskette geometry > > > > > > > > hw/block/fdc.c | 23 +++++++++++++ > > > > hw/i386/acpi-build.c | 92 ++++++++++++++++++++++++++++++++++++-------------- > > > > hw/i386/pc.c | 2 +- > > > > include/hw/block/fdc.h | 2 ++ > > > > include/hw/i386/pc.h | 1 + > > > > 5 files changed, 94 insertions(+), 26 deletions(-) > > > > > > > Michael, we have obtained Reviwed-by: from John. > > > Does this set is good to be accepted or your > > > last comment is mandatory? > > > > Pls do but you can make it a separate patch on top > > if you prefer. > > Sorry I must have lost the track: I thought that all your concerns had > been addressed by John's comment. Can you please point out what issues > still remain in this patchset that prevent it from being merged? > > Thanks, > Roman. it's in my tree so nothing. I prefer refactoring the loop slightly, by patch on top.