From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abfNs-0006lF-9U for qemu-devel@nongnu.org; Thu, 03 Mar 2016 21:22:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abfNr-0007zl-JO for qemu-devel@nongnu.org; Thu, 03 Mar 2016 21:22:28 -0500 Date: Fri, 4 Mar 2016 10:22:08 +0800 From: Peter Xu Message-ID: <20160304022208.GE30973@pxdev.xzpeter.org> References: <1456993272-32292-1-git-send-email-peterx@redhat.com> <1456993272-32292-3-git-send-email-peterx@redhat.com> <20160303115551.oaswd6litrm2tz3v@hawk.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160303115551.oaswd6litrm2tz3v@hawk.localdomain> Subject: Re: [Qemu-devel] [PATCH v2 2/3] arm: qmp: add query-gic-capability interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: wei@redhat.com, peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, armbru@redhat.com, abologna@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org On Thu, Mar 03, 2016 at 12:55:51PM +0100, Andrew Jones wrote: > On Thu, Mar 03, 2016 at 04:21:11PM +0800, Peter Xu wrote: > > + > > +GICCapabilityList *qmp_query_gic_capability(Error **errp); > > I don't know anything about QMP, so just offering a superficial > review comment. Is the prototype necessary here? It seems redundant, > considering the function is defined right below. > > drew I added this to avoid a "missing prototype" warning. However found the correct way to do it is possibly to include "qmp-commands.h" in target-arm/machine.c. Thanks to point out! Will fix. Peter