From: <mgreger@cinci.rr.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QCow2 compression
Date: Fri, 4 Mar 2016 4:24:11 +0000 [thread overview]
Message-ID: <20160304042411.UUWFM.307100.root@dnvrco-web23> (raw)
> > I have for example a compressed cluster with an L2 entry value of 4A
> > C0 00 00 00 3D 97 50. This would lead me to believe the cluster starts
> > at offset 0x3D9750 and has a length of 0x2B 512-byte sectors (or 0x2B
> > times 0x200 = 0x5600). Added to the offset this would give an end for
> > the cluster at offset 0x3DED50. However, it is clear from looking at
> > the image that the compressed cluster extends further, the data ending
> > at 0x3DEDD5 and being followed by some zero padding until 0x3DEDF0
> > where the file ends. How can I know the data extends beyond the length
> > I calculated? Did I misunderstand the documentation somewhere? Why
> > does the file end here versus a cluster aligned offset?
>
> This zero padding happens in the very last cluster in the image in order
> to ensure that the image file is aligned to a multiple of the cluster
> size (qcow2 images are defined to consist of "units of constant size",
> i.e. only full clusters).
>
> The zeros are not part of the compressed data, though, that's why the
> Compressed Cluster Descriptor indicates a shorter size. Had another
> compressed cluster been written to the same image, it might have ended
> up where you are seeing the zero padding now. (The trick with
> compression is that multiple guest clusters can end up in a single host
> cluster.)
>
Thanks, but the given length of 0x5600 is still short by 160(decimal) bytes
compared to the
non-zero data (which occupies an additional 133 bytes beyond the expected end at
0x3DED50) and zero
padding (an additional 27 bytes beyond that). Could there be an off-by-one error
somewhere?
The file doesn't even end on a sector boundary let alone a cluster boundary.
I can replicate this easily and produce files which demonstrate what I am seeing
here.
I will try to replicate using a newer version of the qemu-img. The version in
Debian stable is quite old apparently.
next reply other threads:[~2016-03-04 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 4:24 mgreger [this message]
2016-03-04 22:19 ` [Qemu-devel] QCow2 compression Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2016-03-05 0:11 mgreger
2016-02-27 5:00 mgreger
2016-02-29 14:01 ` Kevin Wolf
2016-02-29 15:58 ` Eric Blake
2016-02-29 14:59 ` Eric Blake
2016-02-29 15:54 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304042411.UUWFM.307100.root@dnvrco-web23 \
--to=mgreger@cinci.rr.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).