From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cjia@nvidia.com>) id 1abjiy-00039b-QY
	for qemu-devel@nongnu.org; Fri, 04 Mar 2016 02:00:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cjia@nvidia.com>) id 1abjiv-0006s1-HZ
	for qemu-devel@nongnu.org; Fri, 04 Mar 2016 02:00:32 -0500
Received: from hqemgate14.nvidia.com ([216.228.121.143]:5399)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cjia@nvidia.com>) id 1abjiv-0006rj-DG
	for qemu-devel@nongnu.org; Fri, 04 Mar 2016 02:00:29 -0500
Date: Thu, 3 Mar 2016 23:00:26 -0800
From: Neo Jia <cjia@nvidia.com>
Message-ID: <20160304070025.GA32070@nvidia.com>
References: <1456244666-25369-1-git-send-email-kwankhede@nvidia.com>
	<1456244666-25369-3-git-send-email-kwankhede@nvidia.com>
	<56D6A68A.50004@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <56D6A68A.50004@intel.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2 3/3] VFIO: Type1 IOMMU mapping
	support for vGPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jike Song <jike.song@intel.com>
Cc: shuai.ruan@intel.com, kevin.tian@intel.com, alex.williamson@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, Kirti Wankhede <kwankhede@nvidia.com>, kraxel@redhat.com, pbonzini@redhat.com, zhiyuan.lv@intel.com

On Wed, Mar 02, 2016 at 04:38:34PM +0800, Jike Song wrote:
> On 02/24/2016 12:24 AM, Kirti Wankhede wrote:
> > +	vgpu_dma->size = map->size;
> > +
> > +	vgpu_link_dma(vgpu_iommu, vgpu_dma);
> 
> Hi Kirti & Neo,
> 
> seems that no one actually setup mappings for IOMMU here?
> 

Hi Jike,

Yes.

The actual mapping should be done by the host kernel driver after calling the
translation/pinning API vgpu_dma_do_translate.

Thanks,
Neo

> > 
> 
> --
> Thanks,
> Jike
>