From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abkS3-00079O-Vo for qemu-devel@nongnu.org; Fri, 04 Mar 2016 02:47:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abkS0-0008KC-Hm for qemu-devel@nongnu.org; Fri, 04 Mar 2016 02:47:07 -0500 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:49909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abkS0-0008K6-7m for qemu-devel@nongnu.org; Fri, 04 Mar 2016 02:47:04 -0500 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Mar 2016 07:47:02 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4B6B02190056 for ; Fri, 4 Mar 2016 07:46:38 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u247ks158913380 for ; Fri, 4 Mar 2016 07:46:54 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u247ksSs020583 for ; Fri, 4 Mar 2016 00:46:54 -0700 Date: Fri, 4 Mar 2016 08:46:53 +0100 From: David Hildenbrand Message-ID: <20160304084653.438d8842@thinkpad-w530> In-Reply-To: <1457040633-30951-8-git-send-email-mjrosato@linux.vnet.ibm.com> References: <1457040633-30951-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1457040633-30951-8-git-send-email-mjrosato@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 7/7] s390x/cpu: Allow hotplug of CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato Cc: imammedo@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net > Implement cpu hotplug routine and add the machine hook. > > Signed-off-by: Matthew Rosato > Reviewed-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 13 +++++++++++++ > target-s390x/cpu.c | 7 +++++++ > 2 files changed, 20 insertions(+) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 7fc1879..174a2f8 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -186,6 +186,18 @@ static HotplugHandler *s390_get_hotplug_handler(MachineState *machine, > return NULL; > } > > +static void s390_hot_add_cpu(const int64_t id, Error **errp) > +{ > + MachineState *machine = MACHINE(qdev_get_machine()); > + Error *err = NULL; > + > + s390_new_cpu(machine->cpu_model, id, &err); > + if (err) { > + error_propagate(errp, err); > + return; > + } You could unconditionally call error_propagate(errp, err); here > +} > + Still looks good to me! David