From: Stefan Hajnoczi <stefanha@redhat.com>
To: Hollis Blanchard <hollis_blanchard@mentor.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] trace: include CPU index in trace_memory_region_*()
Date: Fri, 4 Mar 2016 15:12:57 +0000 [thread overview]
Message-ID: <20160304151257.GD9130@stefanha-x1.localdomain> (raw)
In-Reply-To: <1456949575-1633-1-git-send-email-hollis_blanchard@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Wed, Mar 02, 2016 at 12:12:54PM -0800, Hollis Blanchard wrote:
> Knowing which CPU performed an action is essential for understanding SMP guest
> behavior.
>
> However, cpu_physical_memory_rw() may be executed by a machine init function,
> before any VCPUs are running, when there is no CPU running ('current_cpu' is
> NULL). In this case, store -1 in the trace record as the CPU index. Trace
> analysis tools may need to be aware of this special case.
>
> Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
> ---
> v2: use get_cpu_index() helper function
> ---
> memory.c | 32 ++++++++++++++++++++------------
> trace-events | 8 ++++----
> 2 files changed, 24 insertions(+), 16 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-03-04 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 20:12 [Qemu-devel] [PATCH v2 1/2] trace: include CPU index in trace_memory_region_*() Hollis Blanchard
2016-03-02 20:12 ` [Qemu-devel] [PATCH v2 2/2] trace: separate MMIO tracepoints from TB-access tracepoints Hollis Blanchard
2016-03-07 21:32 ` Hollis Blanchard
2016-03-04 15:12 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304151257.GD9130@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=hollis_blanchard@mentor.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).