From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aclBQ-0005hP-Ly for qemu-devel@nongnu.org; Sun, 06 Mar 2016 21:46:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aclBM-0003Xg-Gz for qemu-devel@nongnu.org; Sun, 06 Mar 2016 21:46:08 -0500 Date: Mon, 7 Mar 2016 13:41:55 +1100 From: David Gibson Message-ID: <20160307024155.GB22546@voom.fritz.box> References: <1457074461-14285-1-git-send-email-bharata@linux.vnet.ibm.com> <1457074461-14285-2-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline In-Reply-To: <1457074461-14285-2-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v1 01/10] exec: Remove cpu from cpus list during cpu_exec_exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mjrosato@linux.vnet.ibm.com, agraf@suse.de, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de, mdroth@linux.vnet.ibm.com --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 04, 2016 at 12:24:12PM +0530, Bharata B Rao wrote: > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > should be removed from cpu_exec_exit(). >=20 > cpu_exec_init() is called from generic CPU::instance_finalize and some > archs like PowerPC call it from CPU unrealizefn. So ensure that we > dequeue the cpu only once. >=20 > Now -1 value for cpu->cpu_index indicates that we have already dequeued > the cpu for CONFIG_USER_ONLY case also. >=20 > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW3OpyAAoJEGw4ysog2bOSLnoP/i3Vdt5GZgrYHYPGdtwLgC0s va6Ht9Oc+ZYEe+ZIMkRhfrroBlI9sx5PM2QZ+7RhI5fYAyypzu+myvJRje/jUuF1 ZY0lG5Kqs02RKmGfSaPY8r6sTJwiDGZBlfTVYtbsc0r/3fmt50Nim9C+58KPt3Fg KlLsPwA7y5mF61Zjy12YXUDDDudQ1tXyzXMLusTkfYGULQs9hxgof2aQJYGDODMg 3LVEVA7qMdZQEjHNrUH48VXLWmXTFhR4j6Fhin/X+AuNkdZd1kPhY1R6w0ptQjfs e2iPND/5b8A0zleZK1ds9MIEGvLdg0c4GwmyinwCmXwFvIcUimn4uc5KBdVXW0nG 3l+p7fnYjNHFIDstlh6YjseswbPe7mMOvdY2afRWqTFmRaGYk2BLEals2drwLSl+ MS2/XpyYBJxHhsNA8z5wITVNHYp0pyjVHFBeAFcZv3nHLN+ChTCnhdA37lqsYVuH 0Qe0Uq7Mog3aOL9fl9UG0HwnvyB9/jFp9Vy6sJ3vN11BFGIQDZKVicXiEBK0DFms fcYCoGUHWLrIvtcit7lF04s0G0es0f3xQqTjFsirekHY82HXnGIVNJ6ZI4v8T7sP LY5AuQr66/WqPEBJMpvNlasfDSEONWAHk5ggrmCgD8DBavfh6X8aZwtcw85JkqEW qQQTBEh+hJFm6cNNCzeI =ZFJL -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8--