From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acm0k-00040D-3H for qemu-devel@nongnu.org; Sun, 06 Mar 2016 22:39:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acm0g-0005LQ-Tz for qemu-devel@nongnu.org; Sun, 06 Mar 2016 22:39:10 -0500 Received: from e28smtp07.in.ibm.com ([125.16.236.7]:42471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acm0g-0005KS-5w for qemu-devel@nongnu.org; Sun, 06 Mar 2016 22:39:06 -0500 Received: from localhost by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Mar 2016 09:09:01 +0530 Date: Mon, 7 Mar 2016 09:08:47 +0530 From: Bharata B Rao Message-ID: <20160307033847.GE5054@in.ibm.com> References: <1457074461-14285-1-git-send-email-bharata@linux.vnet.ibm.com> <1457074461-14285-3-git-send-email-bharata@linux.vnet.ibm.com> <20160307025143.GC22546@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160307025143.GC22546@voom.fritz.box> Subject: Re: [Qemu-devel] [RFC PATCH v1 02/10] exec: Do vmstate unregistration from cpu_exec_exit() Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: mjrosato@linux.vnet.ibm.com, agraf@suse.de, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de, mdroth@linux.vnet.ibm.com On Mon, Mar 07, 2016 at 01:51:43PM +1100, David Gibson wrote: > On Fri, Mar 04, 2016 at 12:24:13PM +0530, Bharata B Rao wrote: > > cpu_exec_init() does vmstate_register and register_savevm for the CPU device. > > These need to be undone from cpu_exec_exit(). These changes are needed to > > support CPU hot removal. > > > > Signed-off-by: Bharata B Rao > > --- > > exec.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/exec.c b/exec.c > > index 7c3f747..b8eeb54 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -613,6 +613,8 @@ static void cpu_release_index(CPUState *cpu) > > > > void cpu_exec_exit(CPUState *cpu) > > { > > + CPUClass *cc = CPU_GET_CLASS(cpu); > > + > > #if defined(CONFIG_USER_ONLY) > > cpu_list_lock(); > > #endif > > @@ -630,6 +632,16 @@ void cpu_exec_exit(CPUState *cpu) > > #if defined(CONFIG_USER_ONLY) > > cpu_list_unlock(); > > #endif > > + > > + if (cc->vmsd != NULL) { > > + vmstate_unregister(NULL, cc->vmsd, cpu); > > + } > > +#if defined(CPU_SAVE_VERSION) && !defined(CONFIG_USER_ONLY) > > + unregister_savevm(NULL, "cpu", cpu->env_ptr); > > +#endif > > + if (qdev_get_vmsd(DEVICE(cpu)) == NULL) { > > + vmstate_unregister(NULL, &vmstate_cpu_common, cpu); > > + } > > } > > > > void cpu_exec_init(CPUState *cpu, Error **errp) > > Looking at the current cpu_exec_init() I'm seeing the > vmstate_register() calls which are balacned here, but not a > register_savevm(). Is that due to a change in cpu_exec_init() since > you first wrote this patch? Yes register_savevm() was removed by 945123a554c3. Will fix this patch in the next iteration. Regards, Bharata.