From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aco5n-0001wC-L4 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 00:52:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aco5j-00057p-J3 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 00:52:31 -0500 Date: Mon, 7 Mar 2016 13:52:22 +0800 From: Fam Zheng Message-ID: <20160307055221.GD21446@ad.usersys.redhat.com> References: <1456747261-22032-1-git-send-email-berrange@redhat.com> <1456747261-22032-6-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456747261-22032-6-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 05/26] crypto: skip testing of unsupported cipher algorithms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org On Mon, 02/29 12:00, Daniel P. Berrange wrote: > We don't guarantee that all crypto backends will support > all cipher algorithms, so we should skip tests unless > the crypto backend indicates support. > > Signed-off-by: Daniel P. Berrange > --- > tests/test-crypto-cipher.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/test-crypto-cipher.c b/tests/test-crypto-cipher.c > index 9f912ec..7a073e9 100644 > --- a/tests/test-crypto-cipher.c > +++ b/tests/test-crypto-cipher.c > @@ -380,7 +380,9 @@ int main(int argc, char **argv) > g_assert(qcrypto_init(NULL) == 0); > > for (i = 0; i < G_N_ELEMENTS(test_data); i++) { > - g_test_add_data_func(test_data[i].path, &test_data[i], test_cipher); > + if (qcrypto_cipher_supports(test_data[i].alg)) { > + g_test_add_data_func(test_data[i].path, &test_data[i], test_cipher); > + } > } > > g_test_add_func("/crypto/cipher/null-iv", > -- > 2.5.0 > Reviewed-by: Fam Zheng