From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acrzY-00037V-5d for qemu-devel@nongnu.org; Mon, 07 Mar 2016 05:02:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acrzV-0001bT-GL for qemu-devel@nongnu.org; Mon, 07 Mar 2016 05:02:20 -0500 Received: from e06smtp06.uk.ibm.com ([195.75.94.102]:60621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acrzV-0001bG-67 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 05:02:17 -0500 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Mar 2016 10:02:15 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5BEAD2190066 for ; Mon, 7 Mar 2016 10:01:56 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u27A2DH9917858 for ; Mon, 7 Mar 2016 10:02:13 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u27A2CE8021861 for ; Mon, 7 Mar 2016 03:02:13 -0700 Date: Mon, 7 Mar 2016 11:02:11 +0100 From: David Hildenbrand Message-ID: <20160307110211.4de13ae5@thinkpad-w530> In-Reply-To: <20160304190310.397979bb@nial.brq.redhat.com> References: <1457040633-30951-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1457040633-30951-7-git-send-email-mjrosato@linux.vnet.ibm.com> <20160304101622.GA5054@in.ibm.com> <20160304120728.0df50c1e@thinkpad-w530> <20160304113129.GC5054@in.ibm.com> <20160304125005.6859b725@thinkpad-w530> <20160304190310.397979bb@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 6/7] s390x/cpu: Add error handling to cpu creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Matthew Rosato , agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, Bharata B Rao , cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net > > After all the discussions about > > -device-add s390-cpu,id=XX > > > > As substitute/addition in the future for hotplug it is the straightforward > > approach to allow setting the id as property. Nobody knows what crazy new > > hotplug method we will come up with. But doing it the device way with properties > > cannot be wrong. And the id is a fundamental concept of a vcpu (cpu-add id=XX). > with device_add 'id' is not a vcpu concept but and arbitrary user supplied string > property owned by Device. But since s390 matches current x86 thread based model it could be migrated to device_add the same way, for example: > device_add s390-cpu,thread=XX So should we name the property thread then? Looks like the id property is really special. What do you suggest? > > > > > So I'd like to avoid reworking everything again, to realize later that we > > want it as a property and rewriting it once again. > for s390, the thing about not rewriting everything once again could be > replacing places where cpu_index is used with CpuClass.arch_id(). > arch_id() defaults to cpu_index but you can later override it with > your own id (whatever s390 uses for identifying cpus on baremetal) > so switching to device_add won't break anything. Okay, this way we could get rid of cpu_index later. David