From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1actH9-0006ZB-FD
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 06:24:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1actH4-0005a9-Cl
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 06:24:35 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:44019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1actH4-0005a4-6E
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 06:24:30 -0500
Date: Mon, 7 Mar 2016 12:24:28 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160307112428.GC5169@var.bordeaux.inria.fr>
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<c207eabadb5773311f980365d0814c366c16999f.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD2582.607@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DD2582.607@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6,
 ICMPv6 Echo and NDP autoconfiguration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote:
> > +    switch (ip6->ip_nh) {
> > +#if 0
> > +    case IPPROTO_TCP:
> > +        tcp_input(m, hlen, (struct socket *)NULL);
> > +        break;
> > +    case IPPROTO_UDP:
> > +        udp_input(m, hlen);
> > +        break;
> > +#endif
> 
> This looks odd, why need this?

To pave the way for the patches after that. We can drop that from this
patch and move to the other ones if you will, I just believe it makes
reading this one easier since it explains how tcp and udp will be
plugged here.

Samuel