From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1actSr-0002Zf-U9
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 06:36:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1actSo-0008Pf-Nc
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 06:36:41 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:41012)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1actSo-0008PW-Hd
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 06:36:38 -0500
Date: Mon, 7 Mar 2016 12:36:35 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160307113635.GD5169@var.bordeaux.inria.fr>
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<a1587e7e751bb5370c19f0af22e7f93a2c61ee49.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD2647.7060003@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DD2647.7060003@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote:
> Part of the codes looks duplicated with ipv4 version. Any chances to
> merge them like tcp?

The duplication is actually quite small: accessing the ip length
is different, filling the address is different, etc.  So there are
differences all along the code.  Is it really worth the factorization?
It seems to me that it would actually *reduce* lisibility.

Samuel