From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1acvJA-0006jx-FE
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:34:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1acvJ7-0002yH-4u
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:34:48 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:47542)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1acvJ6-0002yB-UV
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:34:45 -0500
Date: Mon, 7 Mar 2016 14:34:42 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160307133442.GQ5169@var.bordeaux.inria.fr>
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<a6425369450ce7a2e47cadc2e6f714bcb42cd190.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD25F8.9010602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DD25F8.9010602@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Yann Bordenave <meow@meowstars.org>, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

Jason Wang, on Mon 07 Mar 2016 14:55:52 +0800, wrote:
> On 02/23/2016 03:28 AM, Samuel Thibault wrote:
> > From: Yann Bordenave <meow@meowstars.org>
> >
> > Disambiguation : icmp_error is renamed into icmp_send_error, since it
> > doesn't manage errors, but only sends ICMP Error messages.
> >
> > Adding icmp6_send_error to send ICMPv6 Error messages. This function is
> > simpler than the v4 version.
> > Adding some calls in various functions to send ICMP errors, when a
> > received packet is too big, or when its hop limit is 0.
> 
> Let's split this into two patches to avoid mixing renaming and new
> function introduction.

Ok, done so.

Samuel