From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acvME-0002Xc-37 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:37:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acvMA-0003i2-Pd for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:37:58 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:40610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acvMA-0003hx-Iq for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:37:54 -0500 Date: Mon, 7 Mar 2016 14:37:37 +0100 From: Samuel Thibault Message-ID: <20160307133737.GR5169@var.bordeaux.inria.fr> References: <56DD2430.2090509@redhat.com> <20160307111952.GB5169@var.bordeaux.inria.fr> <56DD6D70.1020209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56DD6D70.1020209@redhat.com> Subject: Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: zhanghailiang , Li Zhijian , Stefan Hajnoczi , Jason Wang , Dave Gilbert , Vasiliy Tolstov , qemu-devel@nongnu.org, Gonglei , Jan Kiszka , Huangpeng , Guillaume Subiron Thomas Huth, on Mon 07 Mar 2016 13:00:48 +0100, wrote: > On 07.03.2016 12:19, Samuel Thibault wrote: > > Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > >> - I expects a unit-test for this. You may want to have a look at the > >> pxe-test in tests/, I think it could be extended to test ipv6 slirp somehow. > > > > It doesn't seem so simple to me. In the case of PXE, you have a guest > > implementation of PXE inside the BIOS. In the case of IPv6, I don't > > think you have a guest implementation of IPv6 in the BIOS... So we'd > > need to embed some guest that would do the IPv6 stuff. At best we can > > make a qtest_start(), and that's about it. > > Maybe we can use qemu-system-pppc64 for this ... the SLOF firmware has > support for IPv6 already. Ah, nice :) > I can have a look at this if you like. Yes. I'm wondering whether that will be in time for the 2.6 window, however. It seems more important to me to get the code more widely tested than adding the unit-test. Samuel