qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, guangrong.xiao@linux.intel.com,
	ehabkost@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	zhaoshenglong@huawei.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API
Date: Mon, 7 Mar 2016 17:28:29 +0200	[thread overview]
Message-ID: <20160307172758-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1457363948-71300-1-git-send-email-imammedo@redhat.com>

On Mon, Mar 07, 2016 at 04:19:02PM +0100, Igor Mammedov wrote:
> Simplify bios_linker API by adding filei name + blob tracking
> so user would have to suppily less arguments which
> reduces chances of mistake by using wrong blob pointer
> with not related file.
> And also refactor API to take file offsets, as it's what
> actually API were doing only internally, instead of
> using host pointers. I hope ti makes it easier for API user
> to use API without need to look at implementation on
> QEMU/SeaBIOS. 


Thanks!
As we are in freeze, I'll probably defer this until after the release though.

> Igor Mammedov (6):
>   acpi: convert linker from GArray to BOISLinker structure
>   acpi: simplify bios_linker API by removing redundant 'table' argument
>   acpi: cleanup bios_linker_loader_cleanup()
>   tpm: apci: cleanup TCPA table initialization
>   acpi: make bios_linker_loader_add_pointer() API offset based
>   acpi: make bios_linker_loader_add_checksum() API offset based
> 
>  hw/acpi/aml-build.c                  |  33 +++----
>  hw/acpi/bios-linker-loader.c         | 179 +++++++++++++++++++++--------------
>  hw/acpi/nvdimm.c                     |   6 +-
>  hw/arm/virt-acpi-build.c             |  51 +++++-----
>  hw/i386/acpi-build.c                 |  89 +++++++++--------
>  include/hw/acpi/aml-build.h          |   7 +-
>  include/hw/acpi/bios-linker-loader.h |  28 +++---
>  include/hw/mem/nvdimm.h              |   3 +-
>  8 files changed, 222 insertions(+), 174 deletions(-)
> 
> -- 
> 1.8.3.1

      parent reply	other threads:[~2016-03-07 15:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 15:19 [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API Igor Mammedov
2016-03-07 15:19 ` [Qemu-devel] [PATCH 1/6] acpi: convert linker from GArray to BOISLinker structure Igor Mammedov
2016-03-07 15:19 ` [Qemu-devel] [PATCH 2/6] acpi: simplify bios_linker API by removing redundant 'table' argument Igor Mammedov
2016-03-07 15:19 ` [Qemu-devel] [PATCH 3/6] acpi: cleanup bios_linker_loader_cleanup() Igor Mammedov
2016-03-07 15:19 ` [Qemu-devel] [PATCH 4/6] tpm: apci: cleanup TCPA table initialization Igor Mammedov
2016-03-07 15:19 ` [Qemu-devel] [PATCH 5/6] acpi: make bios_linker_loader_add_pointer() API offset based Igor Mammedov
2016-03-07 15:19 ` [Qemu-devel] [PATCH 6/6] acpi: make bios_linker_loader_add_checksum() " Igor Mammedov
2016-03-07 15:28 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160307172758-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).