From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acx5S-00068m-Oc for qemu-devel@nongnu.org; Mon, 07 Mar 2016 10:28:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acx5P-0008Kt-BY for qemu-devel@nongnu.org; Mon, 07 Mar 2016 10:28:46 -0500 Date: Mon, 7 Mar 2016 17:28:29 +0200 From: "Michael S. Tsirkin" Message-ID: <20160307172758-mutt-send-email-mst@redhat.com> References: <1457363948-71300-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457363948-71300-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, guangrong.xiao@linux.intel.com, ehabkost@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, zhaoshenglong@huawei.com, pbonzini@redhat.com On Mon, Mar 07, 2016 at 04:19:02PM +0100, Igor Mammedov wrote: > Simplify bios_linker API by adding filei name + blob tracking > so user would have to suppily less arguments which > reduces chances of mistake by using wrong blob pointer > with not related file. > And also refactor API to take file offsets, as it's what > actually API were doing only internally, instead of > using host pointers. I hope ti makes it easier for API user > to use API without need to look at implementation on > QEMU/SeaBIOS. Thanks! As we are in freeze, I'll probably defer this until after the release though. > Igor Mammedov (6): > acpi: convert linker from GArray to BOISLinker structure > acpi: simplify bios_linker API by removing redundant 'table' argument > acpi: cleanup bios_linker_loader_cleanup() > tpm: apci: cleanup TCPA table initialization > acpi: make bios_linker_loader_add_pointer() API offset based > acpi: make bios_linker_loader_add_checksum() API offset based > > hw/acpi/aml-build.c | 33 +++---- > hw/acpi/bios-linker-loader.c | 179 +++++++++++++++++++++-------------- > hw/acpi/nvdimm.c | 6 +- > hw/arm/virt-acpi-build.c | 51 +++++----- > hw/i386/acpi-build.c | 89 +++++++++-------- > include/hw/acpi/aml-build.h | 7 +- > include/hw/acpi/bios-linker-loader.h | 28 +++--- > include/hw/mem/nvdimm.h | 3 +- > 8 files changed, 222 insertions(+), 174 deletions(-) > > -- > 1.8.3.1