From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1adA4L-0005v7-U9
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 00:20:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1adA4L-0002FP-4O
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 00:20:29 -0500
Date: Tue, 8 Mar 2016 13:20:07 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160308052007.GB2377@pxdev.xzpeter.org>
References: <1457324608-11434-1-git-send-email-peterx@redhat.com>
	<1457344554.4468.12.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1457344554.4468.12.camel@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP
	command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrea Bolognani <abologna@redhat.com>
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org

On Mon, Mar 07, 2016 at 10:55:54AM +0100, Andrea Bolognani wrote:
> I tested this both on a v2-only machine
>=20
> =C2=A0 {"return": [
> =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": false, "version": 3, "kernel": fal=
se},
> =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": true, "version": 2, "kernel": true=
}
> =C2=A0 ]}
>=20
> and on a v3-only machine
>=20
> =C2=A0 {"return": [
> =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": false, "version": 3, "kernel": tru=
e},
> =C2=A0=C2=A0=C2=A0=C2=A0{"emulated": true, "version": 2, "kernel": fals=
e}
> =C2=A0 ]}
>=20
> The output looks good to me - I'll leave reviewing the
> implementation to someone with more QEMU knowledge than me, that
> is, any QEMU knowledge at all ;)

Appreciated for helping verify this! :-)

>=20
> One last, purely cosmetic, bit: should the command name be
> query-gic-capabilities rather than query-gic-capability? Any
> native speaker feels like weighing in?

Yah, it seems that "query-gic-capabilities" sounds better. Will use
that in next spin if no one oppose.

Thanks!
Peter