From: Fam Zheng <famz@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vmdk: Switch to heap arrays for vmdk_write_cid
Date: Tue, 8 Mar 2016 15:18:31 +0800 [thread overview]
Message-ID: <20160308071830.GB16648@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160308071042.GC2377@pxdev.xzpeter.org>
On Tue, 03/08 15:10, Peter Xu wrote:
> On Tue, Mar 08, 2016 at 02:18:35PM +0800, Fam Zheng wrote:
> > It is only called once for each opened image, so we can do it the easy
> > way.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > block/vmdk.c | 25 ++++++++++++++-----------
> > 1 file changed, 14 insertions(+), 11 deletions(-)
> >
> > diff --git a/block/vmdk.c b/block/vmdk.c
> > index a8db5d9..1ec2452 100644
> > --- a/block/vmdk.c
> > +++ b/block/vmdk.c
> > @@ -274,36 +274,39 @@ static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent)
> >
> > static int vmdk_write_cid(BlockDriverState *bs, uint32_t cid)
>
> If to use heap in write, do we need to do the same for e.g.,
> vmdk_parent_open() and vmdk_read_cid(), to make all things at least
> aligned?
Yes, let's change them altogether.
Fam
prev parent reply other threads:[~2016-03-08 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 6:18 [Qemu-devel] [PATCH] vmdk: Switch to heap arrays for vmdk_write_cid Fam Zheng
2016-03-08 7:10 ` Peter Xu
2016-03-08 7:18 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308071830.GB16648@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).