From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46543)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=GbGS=PE=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1adDP0-0002wv-2I
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 03:54:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=GbGS=PE=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1adDOw-0006OJ-0L
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 03:54:01 -0500
Received: from domu-toccata.ens-lyon.fr ([140.77.166.138]:59239
	helo=sonata.ens-lyon.org) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from
	<SRS0=GbGS=PE=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1adDOv-0006Nn-PP
	for qemu-devel@nongnu.org; Tue, 08 Mar 2016 03:53:57 -0500
Date: Tue, 8 Mar 2016 09:53:53 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160308085353.GG2663@var.home>
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD2430.2090509@redhat.com>
	<20160307111952.GB5169@var.bordeaux.inria.fr>
	<56DE3D7B.8050902@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DE3D7B.8050902@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu
 -net user mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

Jason Wang, on Tue 08 Mar 2016 10:48:27 +0800, wrote:
> ./scripts/checkpatch.pl
> 0001-slirp-Adding-IPv6-ICMPv6-Echo-and-NDP-autoconfigurat.patch
> ERROR: return is not a function, parentheses are not required
> #177: FILE: slirp/ip6.h:65:
> +    return (a->s6_addr[prefix_len / 8] & ((1U << (8 - (prefix_len %
> 8))) - 1))

This is a false positive, the parentheses here are part of the
expression.

> WARNING: line over 80 characters
> #270: FILE: slirp/ip6_icmp.c:14:
> +#define NDP_Interval g_rand_int_range(slirp->grand,
> NDP_MinRtrAdvInterval, NDP_MaxRtrAdvInterval)

That was a real one yes, introduced when I was asked to use
g_rand_int_range, I have fixed it already.

> WARNING: if this code is redundant consider removing it
> #870: FILE: slirp/ip6_input.c:52:
> +#if 0

That's what we discuss in the other mail.  Yes, we can use comments.  It
just looks odd that we are talking about some code which goes away in a
subsequent patch :)

> >> - The patches do not apply to master cleanly.
> > It did at the time I sent them...
> 
> Right, but not now, so please rebase.

Sure... Already done so.

Samuel