From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adIjO-0006u6-FK for qemu-devel@nongnu.org; Tue, 08 Mar 2016 09:35:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adIjJ-0008Ts-Co for qemu-devel@nongnu.org; Tue, 08 Mar 2016 09:35:26 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:42541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adIjI-0008TZ-Pd for qemu-devel@nongnu.org; Tue, 08 Mar 2016 09:35:21 -0500 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Mar 2016 00:35:13 +1000 Date: Tue, 8 Mar 2016 20:04:12 +0530 From: Bharata B Rao Message-ID: <20160308143412.GA29692@in.ibm.com> References: <1457443095-213125-1-git-send-email-imammedo@redhat.com> <1457443095-213125-5-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457443095-213125-5-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 4/5] spapr: check if cpu core is already present Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mjrosato@linux.vnet.ibm.com, agraf@suse.de, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, afaerber@suse.de, pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, david@gibson.dropbear.id.au On Tue, Mar 08, 2016 at 02:18:14PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > replaced link set check removed in previous patch > --- > hw/ppc/spapr.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 6890a44..db33c29 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2297,6 +2297,27 @@ void *spapr_populate_hotplug_cpu_dt(DeviceState *dev, CPUState *cs, > return fdt; > } > > +static void spapr_machine_device_pre_plug(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > + sPAPRMachineClass *smc = SPAPR_MACHINE_GET_CLASS(hotplug_dev); > + sPAPRMachineState *spapr = SPAPR_MACHINE(hotplug_dev); > + > + if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) { > + int core = object_property_get_int(OBJECT(dev), CPU_CORE_ID_PROP, > + &error_abort); > + > + if (!smc->dr_cpu_enabled && dev->hotplugged) { > + error_setg(errp, "CPU hotplug not supported for this machine"); > + return; > + } > + if (spapr->cores[core]) { > + error_setg(errp, "core %d is already present", core); > + return; > + } Wondering why can't we do the above check from core's realizefn and fail the core hotplug from realizefn ? Regards, Bharata.