From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKWs-00064G-P2 for qemu-devel@nongnu.org; Tue, 08 Mar 2016 11:30:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKWo-00019O-Bg for qemu-devel@nongnu.org; Tue, 08 Mar 2016 11:30:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKWo-00019I-4b for qemu-devel@nongnu.org; Tue, 08 Mar 2016 11:30:34 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B846E720A7 for ; Tue, 8 Mar 2016 16:30:33 +0000 (UTC) Date: Tue, 8 Mar 2016 17:30:31 +0100 From: Kevin Wolf Message-ID: <20160308163031.GG5807@noname.str.redhat.com> References: <1457420446-25276-1-git-send-email-peterx@redhat.com> <1457420446-25276-2-git-send-email-peterx@redhat.com> <87pov5e5w3.fsf@blackfin.pond.sub.org> <20160308101944.GD5807@noname.str.redhat.com> <56DEFC16.6010100@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline In-Reply-To: <56DEFC16.6010100@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: pbonzini@redhat.com, Luiz Capitulino , Markus Armbruster , Peter Xu , qemu-devel@nongnu.org --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 08.03.2016 um 17:21 hat Eric Blake geschrieben: > On 03/08/2016 03:19 AM, Kevin Wolf wrote: > > Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > >> Cc: Kevin, because he added the array in question. > >> > >> Peter Xu writes: > >> >=20 > >> Unrelated to your patch: I think we've pushed QDict use father than > >> sensible. Encoding multiple keys in a string so you can use a flat > >> associative array as your catch-all data structure is appropriate in > >> AWK, but in C? Not so much... > >=20 > > We'll always to that, because it's the command line syntax. What you may > > criticise is that we convert QAPI objects to the command line > > representation instead of the other way around, but changing that (which > > I think would be far from trivial, for relatively little use) wouldn't > > get rid of this kind of key parsing, but just move it a bit closer to > > the command line handling. >=20 > I actually WANT us to try that conversion (a great GSoC project, if > someone wants it) for 2.7. We already did it for SocketAddress, and it > makes the code easier to maintain when you can just access foo->data > instead of doing qdict_lookup(foo, "data") all over the place. I think you're underestimating the difference in difficulty between using SocketAddress everywhere and using BlockdevOptions everywhere, which is the reason why I never even put it on my todo list. Of course, I would be fine with your trying anyway, but it would probably be fairer if we not let a poor student fail with this. Kevin --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJW3v4nAAoJEH8JsnLIjy/W0owP/j8WBwYMmPPA3u325m9+J4q5 nP2NlU9CCha2qD9L9dlPRZm4R5RHKiA6u8McTvjRfjhjC/qcAtw8qh+BLWokc9/w Slb4Bvr4GatSb6uN/Xm/vvaIcduJh2UAIKC/CGWRoa/rCUcrkCtfnFfFAi2FiGiA tIVGFhGDTjrLMOY7dU5mnelpFZUbQ6RUMPH6cqKbVmzkqqZDXClMZlxUTNfoGlx8 9gC+HTMljikpN5bOWtgLcOCFNaMX2QRnhoseWVWHdub2IePQ4COGBEVjkJmCmZPi L831KnsPL8pPjdNfb5cQMQU8zWF7bYsSvhI/swXsve0BUelMhcKyvinmT4778Wxj LjGHCX5e4okTuNoWKOLleB0ewNaeyJjg7Z4MShr+p1WpGiSwA0Yixqrb1Tke4Piy A6drS9ApmAjEai7PULV6rztZEiwHXmIIKXhyDsmHXVvKdh5q3t363PGmA7JFB+JR fZvRJYxOBAcI808cZ8MYeBH0BTAbPY5b9WwEVR7QZPGBv6JWudk1Uso7ZuaOPpsS 9a8K9ji0YCH/o9V1xJIT7b7X7bKz8TRoQ2h17qLps70YxnMsNv4XJO4dBAx1uVOF RCKHVrskQX9ncpMHlqbxaUj7AyeTycO6SD/eFVZFiAaBLXsbImKLPe5zYT0Uk6pE +D23xWAlbzA5w5LJlLmT =XFDe -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/--