From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adT3X-0002YG-MP for qemu-devel@nongnu.org; Tue, 08 Mar 2016 20:36:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adT3T-0007qK-Ij for qemu-devel@nongnu.org; Tue, 08 Mar 2016 20:36:55 -0500 Date: Tue, 8 Mar 2016 18:36:48 -0700 From: Alex Williamson Message-ID: <20160308183648.04a76047@ul30vt.home> In-Reply-To: <20160309005657.GF22546@voom.fritz.box> References: <1457403029-21322-1-git-send-email-david@gibson.dropbear.id.au> <1457403029-21322-2-git-send-email-david@gibson.dropbear.id.au> <20160308113345.28412740@t450s.home> <20160309005657.GF22546@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 1/7] vfio: Start improving VFIO/EEH interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, gwshan@au1.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org On Wed, 9 Mar 2016 11:56:57 +1100 David Gibson wrote: > On Tue, Mar 08, 2016 at 11:33:45AM -0700, Alex Williamson wrote: > > On Tue, 8 Mar 2016 13:10:23 +1100 > > David Gibson wrote: > > > > > At present the code handling IBM's Enhanced Error Handling (EEH) interface > > > on VFIO devices operates by bypassing the usual VFIO logic with > > > vfio_container_ioctl(). That's a poorly designed interface with unclear > > > semantics about exactly what can be operated on. > > > > > > In particular it operates on a single vfio container internally (hence the > > > name), but takes an address space and group id, from which it deduces the > > > container in a rather roundabout way. groupids are something that code > > > outside vfio shouldn't even be aware of. > > > > > > This patch creates new interfaces for EEH operations. Internally we > > > have vfio_eeh_container_op() which takes a VFIOContainer object > > > directly. For external use we have vfio_eeh_as_ok() which determines > > > if an AddressSpace is usable for EEH (at present this means it has a > > > single container with exactly one group attached), and vfio_eeh_as_op() > > > which will perform an operation on an AddressSpace in the unambiguous case, > > > and otherwise returns an error. > > > > > > This interface still isn't great, but it's enough of an improvement to > > > allow a number of cleanups in other places. > > > > > > Signed-off-by: David Gibson > > > Reviewed-by: Alexey Kardashevskiy > > > --- > > > > I'll let you push this through your tree: > > > > Acked-by: Alex Williamson > > Thanks. Any guess at when your vGPU series will be pushed? Mine will > conflict until that is merged upstream. It's been out long enough, I'll send a pull request tomorrow. Thanks, Alex