From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adZA6-00076S-SA for qemu-devel@nongnu.org; Wed, 09 Mar 2016 03:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adZA3-0000yy-Ke for qemu-devel@nongnu.org; Wed, 09 Mar 2016 03:08:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adZA3-0000y8-FW for qemu-devel@nongnu.org; Wed, 09 Mar 2016 03:08:03 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 66C8C7EBCA for ; Wed, 9 Mar 2016 08:08:02 +0000 (UTC) Date: Wed, 9 Mar 2016 16:07:50 +0800 From: Peter Xu Message-ID: <20160309080750.GR2377@pxdev.xzpeter.org> References: <1457420446-25276-1-git-send-email-peterx@redhat.com> <1457420446-25276-5-git-send-email-peterx@redhat.com> <56DEC3E0.1010404@redhat.com> <20160309050812.GK2377@pxdev.xzpeter.org> <56DFD66F.9030900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56DFD66F.9030900@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/8] usb: fix unbounded stack for xhci_dma_write_u32s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Gerd Hoffmann On Wed, Mar 09, 2016 at 08:53:19AM +0100, Paolo Bonzini wrote: > > > On 09/03/2016 06:08, Peter Xu wrote: > > pxdev:bin# gcc -v > > Using built-in specs. > > COLLECT_GCC=/bin/gcc > > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper > > Target: x86_64-redhat-linux > > Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux > > Thread model: posix > > gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) > > > > Do you know why "might not be inlinable"? Failed to figure it out > > myself as mentioned in cover letter.. > > It's just a difference in compiler versions. But ARRAY_SIZE should be > enough to fix it. It's dynamically allocated in stack, can we still use ARRAY_SIZE in this case? Maybe for this case, best to use both stack and heap? malloc only if buffer big enough. Peter