From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adbsD-0004xu-A8 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 06:01:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adbsA-0005Ya-02 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 06:01:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adbs9-0005YM-R0 for qemu-devel@nongnu.org; Wed, 09 Mar 2016 06:01:45 -0500 Date: Wed, 9 Mar 2016 16:31:25 +0530 From: Amit Shah Message-ID: <20160309110125.GO15443@grmbl.mre> References: <1456372227-10380-1-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3 0/2] Fix flaw of qemu_put_compression_data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Li, Liang Z" Cc: "zhang.zhanghailiang@huawei.com" , "qemu-devel@nongnu.org" , "dgilbert@redhat.com" , "quintela@redhat.com" On (Wed) 09 Mar 2016 [08:41:41], Li, Liang Z wrote: > > > -----Original Message----- > > From: Li, Liang Z > > Sent: Thursday, February 25, 2016 11:50 AM > > To: quintela@redhat.com; amit.shah@redhat.com > > Cc: qemu-devel@nongnu.org; dgilbert@redhat.com; > > zhang.zhanghailiang@huawei.com; Li, Liang Z > > Subject: [PATCH v3 0/2] Fix flaw of qemu_put_compression_data > > > > The implementation of qemu_put_compression_data only consider the case > > QEMUFile is writable, it can't work with a writable QEMUFile and does not > > provide any measure to prevent users from using it with a writable QEMUFile. > > For safety, it should be improved to avoid some issues. > > > > ram_save_compressed_page can be refined based on the change of > > qemu_put_compression_data, very small improvement, but code looks > > better. > > > > Liang Li (2): > > qemu-file: Fix qemu_put_compression_data flaw > > migration: refine ram_save_compressed_page > > > > migration/qemu-file.c | 23 +++++++++++++++++++++-- > > migration/ram.c | 34 ++++++++++++++++++---------------- > > 2 files changed, 39 insertions(+), 18 deletions(-) > > Hi Juan & Amit, > > How about this patch set? I know Juan had some reservations. Don't know if all his concerns were addressed. I'll let him decide on this one. Amit