From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adx6Z-0007Ul-0B for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:42:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adx6V-0003gJ-P4 for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:42:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adx6V-0003gC-KB for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:41:59 -0500 Date: Thu, 10 Mar 2016 09:41:55 +0000 From: "Daniel P. Berrange" Message-ID: <20160310094155.GD25607@redhat.com> References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-13-git-send-email-berrange@redhat.com> <56E061B1.9040706@redhat.com> <56E08098.5050403@redhat.com> <56E094A3.5010103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56E094A3.5010103@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for win32 using WSAEventSelect+select Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Weil , qemu-devel@nongnu.org, Andrew Baumann On Wed, Mar 09, 2016 at 10:24:51PM +0100, Paolo Bonzini wrote: > > > On 09/03/2016 20:59, Eric Blake wrote: > > On 03/09/2016 10:47 AM, Paolo Bonzini wrote: > >> > On 09/03/2016 18:28, Daniel P. Berrange wrote: > >>> >> From: Paolo Bonzini > >> > > >> > Reviewing my own patch looks weird. :) > >> > > >>> >> On Win32 we cannot directly poll on socket handles. Instead we > >>> >> create a Win32 event object and associate the socket handle with > >>> >> the event. When the event signals readyness we then have to > >>> >> use select to determine which events are ready. Creating Win32 > >>> >> events is moderately heavyweight, so we don't want todo it > >>> >> every time we create a GSource, so this associates a single > >>> >> event with a QIOChannel. > >>> >> > >>> >> Signed-off-by: Daniel P. Berrange > >>> >> --- > > Especially when it lacks your S-o-b :) > > I'm innocent! :) > > https://github.com/bonzini/qemu/commit/win32-qio-watch^ Since I made non-trivial changes to this commit, I thought it was corrrect to remove your S-o-b, to avoid claiming that you'd already signed off on the changes I made. Was that not the right thing todo ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|