From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae1vP-0001kI-5c for qemu-devel@nongnu.org; Thu, 10 Mar 2016 09:50:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae1vL-0000R9-V4 for qemu-devel@nongnu.org; Thu, 10 Mar 2016 09:50:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae1vL-0000QP-P2 for qemu-devel@nongnu.org; Thu, 10 Mar 2016 09:50:47 -0500 Date: Thu, 10 Mar 2016 14:50:43 +0000 From: "Daniel P. Berrange" Message-ID: <20160310145043.GP25607@redhat.com> References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-15-git-send-email-berrange@redhat.com> <56E06237.3060500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56E06237.3060500@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 14/21] char: remove qemu_chr_finish_socket_connection method Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Weil , qemu-devel@nongnu.org, Andrew Baumann On Wed, Mar 09, 2016 at 06:49:43PM +0100, Paolo Bonzini wrote: > > > On 09/03/2016 18:28, Daniel P. Berrange wrote: > > @@ -3131,7 +3118,9 @@ static bool qemu_chr_open_socket_fd(CharDriverState *chr, Error **errp) > > if (qio_channel_socket_listen_sync(sioc, s->addr, errp) < 0) { > > goto fail; > > } > > - qemu_chr_finish_socket_connection(chr, sioc); > > + s->listen_ioc = sioc; > > + s->listen_tag = qio_channel_add_watch( > > + QIO_CHANNEL(s->listen_ioc), G_IO_IN, tcp_chr_accept, chr, NULL); > > } else if (s->reconnect_time) { > > qio_channel_socket_connect_async(sioc, s->addr, > > qemu_chr_socket_connected, > > Aha, yes, this could be it. If you move WSAEventSelect to > qio_channel_set_blocking, the previous patch will probably become > unnecessary. Yes, I've tested that and you're correct, so I've dropped the previous patch. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|