From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ae1y4-0005TK-Ik
	for qemu-devel@nongnu.org; Thu, 10 Mar 2016 09:53:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ae1y1-0001vG-DD
	for qemu-devel@nongnu.org; Thu, 10 Mar 2016 09:53:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58042)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ae1y1-0001v8-7H
	for qemu-devel@nongnu.org; Thu, 10 Mar 2016 09:53:33 -0500
Date: Thu, 10 Mar 2016 14:53:28 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160310145328.GS25607@redhat.com>
References: <1457544504-8548-1-git-send-email-berrange@redhat.com>
	<1457544504-8548-19-git-send-email-berrange@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1457544504-8548-19-git-send-email-berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32
 specific closesocket/ioctlsocket
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Stefan Weil <sw@weilnetz.de>

On Wed, Mar 09, 2016 at 05:28:21PM +0000, Daniel P. Berrange wrote:
> Now that QEMU replaces the close() and ioctl() methods with
> a wrapper that can transparently handle both sockets and
> regular file handles on Win32, there is no need to ever
> use the closesocket/ioctlsocket methods. The code can simply
> use the normal POSIX methods.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  block/sheepdog.c           | 36 ++++++++++++++++++------------------
>  include/qemu/sockets.h     |  4 ----
>  io/channel-socket.c        |  2 +-
>  migration/qemu-file-unix.c |  2 +-
>  migration/tcp.c            |  4 ++--
>  net/socket.c               | 20 ++++++++++----------
>  slirp/ip_icmp.c            |  2 +-
>  slirp/misc.c               |  4 ++--
>  slirp/slirp.h              |  2 --
>  slirp/socket.c             |  2 +-
>  slirp/tcp_subr.c           |  6 +++---
>  slirp/udp.c                |  2 +-
>  util/qemu-sockets.c        | 12 ++++++------
>  13 files changed, 46 insertions(+), 52 deletions(-)

Given feedback from Paolo on the previous patch, I'm dropping this
patch.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|